Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested directory xrefs in combined PDFs #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erilot
Copy link

@erilot erilot commented Nov 18, 2019

All links between pages work, regardless of directory structure and nesting, from any level to any other level.

Note that this works, but I did it under fire and under deadline and wasn't thinking about nice code, so I probably messed up your organization and file grouping. Please make sure it's up to standards. Happy to revise/edit per your guidance.

Couple of other notes:

  • There is a hardcoded reference to the site directory in plugin.py which should be pulled from the config instead, but I couldn't figure out how to make that work and ran out of time. It is commented in the file.
  • I added a console print statement that provides feedback as to which page is being processed as some of these runs take a long time (90+sec for our docs). This is unrelated to this issue and should have been committed separately. Whoops.

Links between pages work regardless of document structure and nesting
Note, contains a hardcoded site directory value in plugin.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant