Feat: enable encryption support for SMB #1271
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Before we go on, yes I've read your PR template, yes I'm aware that you don't accept contributions 1:1. The PR is trivial however, consider this to be in the public domain.
Mostly just want to get the ball rolling into the right direction)
I have a few shares on the same samba host (linux box) that has for some of those shares enforced encryption
The smb library you are using by default doesn't negotiate encryption support, if you connect to the host, leading to EPERM when the home share gets accessed as an example, while the media share is still accessible.
In order that the encryption support is actually enabled by the lib, you need to do so with the config builder.
Not sure if you want to unconditionally do so or if this needs to be some sort of frontend setting, but as you anyway want to do the coding on your own I didn't bother trying to do so.