Skip to content

Commit

Permalink
Feat: Remove Stetho
Browse files Browse the repository at this point in the history
Stetho has been archived for a long while.
  • Loading branch information
zhanghai committed Mar 1, 2024
1 parent b95dbc1 commit 60da95b
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 16 deletions.
4 changes: 0 additions & 4 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ repositories {
dependencies {
implementation 'com.github.zhanghai:dav4jvm:59aa867'
implementation 'com.github.chrisbanes:PhotoView:2.3.0'
releaseImplementation 'com.github.mypplication:stetho-noop:1.1'
implementation 'com.github.topjohnwu.libsu:service:5.2.2'
}

Expand Down Expand Up @@ -140,9 +139,6 @@ dependencies {
implementation 'com.caverock:androidsvg-aar:1.4'
implementation 'com.davemorrissey.labs:subsampling-scale-image-view-androidx:3.10.0'
implementation 'com.drakeet.drawer:drawer:1.0.3'
debugImplementation 'com.facebook.stetho:stetho:1.6.0'
// If added along with okhttp3, remove the related dontwarn from proguard-rules.pro.
//debugImplementation 'com.facebook.stetho:stetho-okhttp3:1.6.0'
implementation 'com.h6ah4i.android.materialshadowninepatch:materialshadowninepatch:1.0.0'
implementation 'com.h6ah4i.android.widget.advrecyclerview:advrecyclerview:1.0.0'
implementation ('com.hierynomus:smbj:0.13.0') {
Expand Down
4 changes: 0 additions & 4 deletions app/proguard-rules.pro
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,3 @@

# SMBJ-RPC
-dontwarn java.rmi.UnmarshalException

# Stetho No-op
# This library includes the no-op for stetho-okhttp3 which requires okhttp3, but we never used it.
-dontwarn com.facebook.stetho.okhttp3.StethoInterceptor
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ package me.zhanghai.android.files.app
import android.os.AsyncTask
import android.os.Build
import android.webkit.WebView
import com.facebook.stetho.Stetho
import com.jakewharton.threetenabp.AndroidThreeTen
import jcifs.context.SingletonContext
import me.zhanghai.android.files.BuildConfig
Expand All @@ -33,9 +32,9 @@ import me.zhanghai.android.files.provider.webdav.client.Client as WebDavClient

val appInitializers = listOf(
::initializeCrashlytics, ::disableHiddenApiChecks, ::initializeThreeTen,
::initializeWebViewDebugging, ::initializeStetho, ::initializeCoil,
::initializeFileSystemProviders, ::upgradeApp, ::initializeLiveDataObjects,
::initializeCustomTheme, ::initializeNightMode, ::createNotificationChannels
::initializeWebViewDebugging, ::initializeCoil, ::initializeFileSystemProviders, ::upgradeApp,
::initializeLiveDataObjects, ::initializeCustomTheme, ::initializeNightMode,
::createNotificationChannels
)

private fun initializeCrashlytics() {
Expand All @@ -58,10 +57,6 @@ private fun initializeWebViewDebugging() {
}
}

private fun initializeStetho() {
Stetho.initializeWithDefaults(application)
}

private fun initializeFileSystemProviders() {
FileSystemProviders.install()
FileSystemProviders.overflowWatchEvents = true
Expand Down

0 comments on commit 60da95b

Please sign in to comment.