[zend-view] Updated HeadScript to allow for proper html5 syntax creation #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2021
glensc
changed the title
|
Nice! could we have a test perhaps 😅 |
falkenhawk
requested changes
Oct 4, 2022
|
@falkenhawk I don't think I will be working on this. you can close if you don't plan to take over. |
Signed-off-by: Elan Ruusamäe <[email protected]>
Signed-off-by: Elan Ruusamäe <[email protected]>
Signed-off-by: Elan Ruusamäe <[email protected]>
Signed-off-by: Elan Ruusamäe <[email protected]>
falkenhawk
force-pushed
the
zf1-future-107
branch
from
e203046
to
2406a4e
Compare
- it was rendering a html attribute for `false` value which is the opposite of what's expected - render attribute in minimized form when value is empty string, true or same as attribute name - added a test
falkenhawk
force-pushed
the
zf1-future-107
branch
from
4e7a1cd
to
53516cf
Compare
falkenhawk
approved these changes
Feb 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Nazin
cc @GK89