N'envoie pas à Sentry les KeyboardInterrupt
#6678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quand on lance une commande
manage.pyet qu'on l'interrompt avec Ctrl+C, cela génère une exceptionKeyboardInterruptqui est envoyée à Sentry, puisque c'est une exception non rattrapée par notre code. Cependant, ça n'a pas vraiment de sens d'enregistrer ça dans Sentry, puisque c'est forcément un être humain qui a provoqué consciemment et volontairement laKeyboardInterrupt. Autrement dit : ce n'est pas un vrai problème et l'utilisateur a connaissance immédiatement de l'exception ; bref, ça n'a rien à faire dans Sentry :)Contrôle qualité
J'ai testé sur la bêta, ça fonctionne les
KeyboardInterruptne sont plus envoyées à Sentry.J'ai suivi cette documentation.