Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajoute une page « Accessibilité » #6673

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Ajoute une page « Accessibilité » #6673

merged 6 commits into from
Nov 1, 2024

Conversation

jpbelval
Copy link
Contributor

Ajoute une page de déclaration d'accessibilité pour ZdS avec un lien en pied de page.

Fix #6657

Contrôle qualité

@coveralls
Copy link

coveralls commented Oct 21, 2024 •
edited
Loading

Coverage Status

coverage: 89.206% (+0.001%) from 89.205%
when pulling f2ea00a on jpbelval:feature/page-accessibilite
into aaeb44d on zestedesavoir:dev.

AmauryCarrade
AmauryCarrade requested changes Oct 21, 2024
View reviewed changes
Copy link
Member

@AmauryCarrade AmauryCarrade left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci beaucoup pour ta contribution !

Un petit détail suite à réflexion (divergeant du ticket initial) et une question que je me pose, mais sinon, sounds good

templates/pages/accessibilite.html Outdated Show resolved Hide resolved
templates/pages/accessibilite.html Outdated Show resolved Hide resolved
templates/footer.html Outdated Show resolved Hide resolved
@jpbelval
Copy link
Contributor Author

Je crois avoir ajouté les suggestions, n'hésitez pas si il manque quoi que ce soit.

@AmauryCarrade AmauryCarrade added S-Évolution Ajoute de nouvelles fonctionnalités C-Accessibility Concerne l’accessibilité du site ou des documents générés labels Oct 22, 2024
AmauryCarrade
AmauryCarrade previously approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@AmauryCarrade AmauryCarrade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je n’ai pas fait de QA sur un navigateur, mais en lisant le code, tout me semble bon !

Arnaud-D
Arnaud-D requested changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@Arnaud-D Arnaud-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Faudrait au moins corriger la faute d'orthographe dans la première phrase de la page.

Le reste, je n'en mourrais pas. :)

templates/pages/accessibilite.html Outdated Show resolved Hide resolved
templates/pages/accessibilite.html Outdated Show resolved Hide resolved
zds/settings/abstract_base/zds.py Outdated Show resolved Hide resolved
zds/pages/views.py Outdated Show resolved Hide resolved
zds/pages/views.py Outdated Show resolved Hide resolved
Situphen
Situphen previously requested changes Oct 23, 2024
View reviewed changes
Copy link
Member

@Situphen Situphen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merci pour cette contribution ! J'ai juste quelques remarques supplémentaires, rien de bien méchant :)

templates/footer.html Outdated Show resolved Hide resolved
zds/pages/views.py Outdated Show resolved Hide resolved
zds/pages/urls.py Outdated Show resolved Hide resolved
@AmauryCarrade
Copy link
Member 

ImportError: cannot import name 'accessibilite' from 'zds.pages.views' (/home/runner/work/zds-site/zds-site/zds/pages/views.py)

Il semblerait que tu aies renommé la vue accessibilite en accessibility sans renommer ses usages 😛 rien de bien méchant à corriger a priori (désolé pour les nombreux allers-retours !)

@AmauryCarrade
Copy link
Member

Comme tu as autorisé les modifications par les mainteneurices, je me suis permis de corriger directement ce petit oubli tout simple (attention de mettre à jour ton dépôt local, @jpbelval)

Arnaud-D
Arnaud-D approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@Arnaud-D Arnaud-D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA OK ✔️

@Arnaud-D Arnaud-D enabled auto-merge (squash) November 1, 2024 18:21
@Arnaud-D Arnaud-D merged commit a6ae90d into zestedesavoir:dev Nov 1, 2024
12 checks passed
@jpbelval jpbelval deleted the feature/page-accessibilite branch November 1, 2024 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmauryCarrade AmauryCarrade AmauryCarrade left review comments

@philippemilink philippemilink philippemilink left review comments

@Arnaud-D Arnaud-D Arnaud-D approved these changes

@Situphen Situphen Awaiting requested review from Situphen

Assignees
No one assigned
Labels
C-Accessibility Concerne l’accessibilité du site ou des documents générés S-Évolution Ajoute de nouvelles fonctionnalités
Projects
Suivi des PR
Status: Fusionnée
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ajouter une page « Accessibilité »
6 participants
@jpbelval @coveralls @AmauryCarrade @philippemilink @Situphen @Arnaud-D