Skip to content

Commit

Permalink
No longer bundle libzmq with IPC support
Browse files Browse the repository at this point in the history
due to bugs that cause crashes that can't be worked around

wait for at least 4.3.5 before re-enabling
  • Loading branch information
minrk committed Sep 9, 2022
1 parent 5dfeaaf commit ab2ab03
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 6 deletions.
11 changes: 9 additions & 2 deletions buildutils/bundle.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,19 @@
ROOT = os.path.dirname(HERE)


# msvc 142 builds have a problem:
# on _some_ (unclear which!) systems due to the implementation of runtime detection of AF_UNIX
# in 4.3.4
vcversion = 141
# until that's fixed, we shouldn't ship 142 builds,
# which in turn means we can't support IPC in wheels

if platform.architecture()[0] == '64bit':
msarch = '-x64'
vcversion = 142
# vcversion = 142
else:
msarch = ''
vcversion = 141
# vcversion = 141

libzmq_dll = f"libzmq-v{vcversion}{msarch}-{x}_{y}_{z}.zip"
libzmq_dll_url = f"{download_url}/{libzmq_dll}"
Expand Down
10 changes: 6 additions & 4 deletions tools/test_wheel.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import os
import platform
import sys
from unittest import SkipTest

import pytest

Expand All @@ -18,10 +17,13 @@ def test_has(feature):
if (
feature == 'ipc'
and sys.platform == 'win32'
and platform.architecture()[0] == '32bit'
and platform.python_implementation() == "CPython"
):
raise SkipTest("32b Windows doesn't have ipc")
assert zmq.has(feature)
# Windows wheels lack IPC
# pending release with https://github.com/zeromq/libzmq/pull/4422
assert not zmq.has(feature)
else:
assert zmq.has(feature)


def test_simple_socket():
Expand Down

0 comments on commit ab2ab03

Please sign in to comment.