fall thru to tcp/ip for any AF_UNIX/ipc error

[pjaggi1]

zeromq/pyzmq#1505
a few pyzmq clients have encountered an issue where the program they're running ends after this assert:
Bad file descriptor (C:\ci\zeromq_1602704446950\work\src\epoll.cpp:100)

We found this happens for users that have a windows 10 build that supports AF_Unix sockets but does not for those who have older windows 10 builds. this change is to remove the preserved errno (which doesn't appear to be used/checked anywhere-hence the later assert/abort) and instead after cleanup try to use a tcp/ip socket.

[bluca]

Uh? This doesn't make much sense, there's already a skip-ahead if the socket creation fails

[bluca]

libzmq/src/ip.cpp

Line 584 in 37224c9

goto try_tcpip;

[pjaggi1]

Uh? This doesn't make much sense, there's already a skip-ahead if the socket creation fails

in our case and in some of these other cases its not necessarily the socket creation that fails (for us it was the bind).

[bluca]

Uh? This doesn't make much sense, there's already a skip-ahead if the socket creation fails

in our case and in some of these other cases its not necessarily the socket creation that fails (for us it was the bind).

Weird, but ok, then please add a proper check for that specific errno after the failed bind, and if it happens, close the socket and jump to the try-tcp.

Also please add a relicense statement https://github.com/zeromq/libzmq/tree/master/RELICENSE

[songjt1993]

I had the same problem. Will this pr be merged into master? How long will it take to see it in the release version

[bluca]

Closing in favor of #4422

[Godsix]

I had the same problem.And I found conditions:①Windows 10 username contain no-ASCII Characters,such as Chinese Characters;②libzmq was compiled with msvc v142 or v143.
I compile pyzmq with libzmq-v141,it‘s OK.
Before developers solve the problem,user can avoid the problem by replacing to with libzmq-v141.

[Godsix]

I had the same problem.And I found conditions:①Windows 10 username contain no-ASCII Characters,such as Chinese Characters;②libzmq was compiled with msvc v142 or v143. I compile pyzmq with libzmq-v141,it‘s OK. Before developers solve the problem,user can avoid the problem by replacing to with libzmq-v141.

So this problem mostly occurs in non-English speaking countries, because they are more likely to use non-ASCII characters as Windows username.