-
Notifications
You must be signed in to change notification settings - Fork 593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MATLAB code analyzer #3018
Add MATLAB code analyzer #3018
Conversation
6124ec7
to
3be48da
Compare
@@ -97,54 +97,6 @@ runs: | |||
shell: powershell | |||
if: runner.os == 'Windows' | |||
|
|||
# |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the MATLAB setup to a separate action to be able to use it from both CI and MATLAB Analyzer workflows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't both workflows use setup-dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem was how setup-dependencies detect if MATLAB has to be installed:
if: runner.os == 'Linux' && matrix.config == 'matlab'
There is no matrix config with the new job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option is to add another bool input parameter to setup-dependences to indicate if Matlab should be installed. It would keep the setup in one spot.
This PR runs the MATLAB code analyzer on CI. I also include fixes for some of the issues reported by this analyzer.