Update Logger API in C++ #3013
Merged
Update Logger API in C++ #3013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepone
approved these changes
Oct 30, 2024
cpp/src/Ice/LoggerI.cpp
Outdated
| @@ -25,15 +25,15 @@ namespace | |||
| const chrono::minutes retryTimeout = chrono::minutes(5); | |||
| } | |||
|
|
|||
| Ice::LoggerI::LoggerI(const string& prefix, const string& file, bool convert, size_t sizeMax) | |||
| : _prefix(prefix), | |||
| Ice::LoggerI::LoggerI(string prefix, const string& file, bool convert, size_t sizeMax) | |||
There was a problem hiding this comment.
Fixed. The logic here was to update the public API but leave internal uses of const string& alone.
cpp/src/Ice/OSLogLoggerI.cpp
Outdated
| { | ||
| const string subsystem = prefix.empty() ? "com.zeroc.ice" : "com.zeroc.ice." + prefix; | ||
| const string subsystem = _prefix.empty() ? "com.zeroc.ice" : "com.zeroc.ice." + _prefix; |
There was a problem hiding this comment.
Not directly related, but we should probably make subsystem a member, we use it in trace too.
cpp/src/Ice/SysLoggerI.cpp
Outdated
| @@ -12,7 +12,7 @@ using namespace std; | |||
| using namespace Ice; | |||
| using namespace IceInternal; | |||
|
|
|||
| Ice::SysLoggerI::SysLoggerI(const string& prefix, const string& facilityString) : _facility(0), _prefix(prefix) | |||
| Ice::SysLoggerI::SysLoggerI(string prefix, const string& facilityString) : _facility(0), _prefix(std::move(prefix)) | |||
There was a problem hiding this comment.
Why do we keep facilityString as a reference?
There was a problem hiding this comment.
Fixed. See earlier comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More string updates, mostly for the Logger API.