fix(matrix-client/tgc): prevent social channels from being mapped as one-on-ones to ensure proper room state #2365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ner when the conversation is valid (active)
…prevent hanging state on unexpected errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Prevents rooms with a social channel type from being incorrectly mapped as one-on-one conversations, ensuring they are recognized as group conversations with appropriate group management features and correct room state.
Why are we making this change?
To avoid incorrect UI behavior that occurs when social channels are treated as one-on-ones, which disrupts group management functionality such as adding/removing members and managing group settings.
How do I test this?
Key decisions and Risk Assessment:
Things to consider: