Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(group-management/chat-sagas): open secondary side kick by default if social channel #2324

Merged

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Oct 4, 2024

What does this do?

  • opens secondary side kick by default if social channel

Why are we making this change?

  • as requested

How do I test this?

  • run tests as usual
  • run ui and test by hitting social channel conversation id in url

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested review from ratik21 and a team and removed request for ratik21 October 4, 2024 12:10
@domw30 domw30 merged commit d997944 into main Oct 4, 2024
5 checks passed
@domw30 domw30 deleted the feat/open-secondary-side-kick-by-default-if-social-channel branch October 4, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant