Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feed-view): handle loading state and add loading spinner to indicate more posts loading when triggering fetchMore on posts #2314

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

domw30
Copy link
Collaborator

@domw30 domw30 commented Oct 3, 2024

What does this do?

  • when triggering fetching more posts, add loading state condition and render loading spinner

Why are we making this change?

  • improve ui / ux by indicating loading of fetching more posts

How do I test this?

  • run tests as usual.
  • run ui and load more posts on social channels

Key decisions and Risk Assessment:

Things to consider:

  1. How will this affect security?
  2. How will this affect performance?
  3. Does this change any APIs?

@domw30 domw30 requested a review from a team October 3, 2024 10:40
@domw30 domw30 merged commit 1a85264 into main Oct 3, 2024
5 checks passed
@domw30 domw30 deleted the feat/add-loading-spinner-when-fetching-more-posts branch October 3, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant