-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manifest: Give the option to get BabbleSim via the manifest #55696
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
091db62
to
74acb04
Compare
Built and ran the gatt settings test successfully with the bsim fetched using this PR. |
@aescolar Regarding the following documentation build failure, you can cherry-pick 6c0b695 to fix the issue.
|
Added DNM following @nashif request for further discussion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good direction.
Let's take this one step further 😃
Cmake changes will be postponed to another PR
To facilitate users experience, fetch the required BabbleSim components using the west manifest. Until now, users would need to either use the Zephyr docker image, or fetch bsim on their own. For many years there has been a request to automate this process. This is the first step. Signed-off-by: Alberto Escolar Piedras <[email protected]>
This commit updates the documentation build workflow to pull in the 'bsim' west project (with its submanifest) so that the build process does not fail due to a manifest import failure. Signed-off-by: Stephanos Ioannidis <[email protected]> Signed-off-by: Alberto Escolar Piedras <[email protected]>
This breaks |
Babblesim has been in the manifest as an optional set of west projects since zephyrproject-rtos#55696 and zephyrproject-rtos#59023 In principle we need one entry in the MAINTAINERS file per west project, but as these project are optional, entries for them were never added. If a user has these babblesim project group enabled locally, checkcompliance MaintainersFormat check will warn though. So let's fix this by adding the respective entries in the MAINTAINERS file. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Babblesim has been in the manifest as an optional set of west projects since #55696 and #59023 In principle we need one entry in the MAINTAINERS file per west project, but as these project are optional, entries for them were never added. If a user has these babblesim project group enabled locally, checkcompliance MaintainersFormat check will warn though. So let's fix this by adding the respective entries in the MAINTAINERS file. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Babblesim has been in the manifest as an optional set of west projects since zephyrproject-rtos/zephyr#55696 and zephyrproject-rtos/zephyr#59023 In principle we need one entry in the MAINTAINERS file per west project, but as these project are optional, entries for them were never added. If a user has these babblesim project group enabled locally, checkcompliance MaintainersFormat check will warn though. So let's fix this by adding the respective entries in the MAINTAINERS file. (cherry picked from commit eddb382) Original-Signed-off-by: Alberto Escolar Piedras <[email protected]> GitOrigin-RevId: eddb382 Change-Id: Ieee5cae1c22fc7b1ec2303cec4150d6e34cc8f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/5482306 Tested-by: ChromeOS Prod (Robot) <[email protected]> Tested-by: Dawid Niedźwiecki <[email protected]> Reviewed-by: Dawid Niedźwiecki <[email protected]> Commit-Queue: Dawid Niedźwiecki <[email protected]>
Babblesim has been in the manifest as an optional set of west projects since zephyrproject-rtos#55696 and zephyrproject-rtos#59023 In principle we need one entry in the MAINTAINERS file per west project, but as these project are optional, entries for them were never added. If a user has these babblesim project group enabled locally, checkcompliance MaintainersFormat check will warn though. So let's fix this by adding the respective entries in the MAINTAINERS file. Signed-off-by: Alberto Escolar Piedras <[email protected]>
Babblesim has been in the manifest as an optional set of west projects since zephyrproject-rtos#55696 and zephyrproject-rtos#59023 In principle we need one entry in the MAINTAINERS file per west project, but as these project are optional, entries for them were never added. If a user has these babblesim project group enabled locally, checkcompliance MaintainersFormat check will warn though. So let's fix this by adding the respective entries in the MAINTAINERS file. Signed-off-by: Alberto Escolar Piedras <[email protected]>
To improve users experience, give the option to users to fetch the required BabbleSim components using the west manifest.
Until now, users would need to either use the Zephyr docker image, or fetch bsim on their own.
For many years there has been a request to automate this process. This is the first step.
Fixes #55698
Note: A set of follow ups could/would:
the simulator is are not set. aescolar@9e331be