Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qdec: same70b: Fix missing TC_CMR definitions #35

Merged
merged 1 commit into from
Jan 28, 2024
Merged

qdec: same70b: Fix missing TC_CMR definitions #35

merged 1 commit into from
Jan 28, 2024

Conversation

tswaehn
Copy link
Contributor

@tswaehn tswaehn commented Nov 22, 2023

fixes: zephyr #65432

@tswaehn tswaehn mentioned this pull request Nov 22, 2023
Closed
@nandojve nandojve self-requested a review November 22, 2023 21:20
nandojve
nandojve requested changes Nov 26, 2023
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tswaehn ,

The change is fine. You just need follow the procedures in the README in landing page.

For instance, check d329fd6:

Keep same brief and description structure and update README.

Then, you need to link this update with a PR in Zephyr to update the HAL.

@tswaehn tswaehn force-pushed the fix_65432 branch 2 times, most recently from eda5d3a to 2ff1286 Compare January 27, 2024 20:25
@tswaehn
qdec: SAME70b: Fix missing TC_CMR definitions
91d91c2 
The TC_CMR definitions were there for SAME70. However there is a newer revsion SAME70b, which

was missing these definitions. With this fix, the definitions are added and issue zephyr#65432

can be resolved.

Signed-off-by: Sven Ginka <[email protected]>
@nandojve nandojve changed the title copy paste the definition of CMR registers from same70q21 to same70q21b qdec: same70b: Fix missing TC_CMR definitions Jan 28, 2024
nandojve
nandojve approved these changes Jan 28, 2024
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tswaehn ,

I've been flexible with commit messages but I ask to start to follow the README.

@nandojve nandojve merged commit aad79bf into zephyrproject-rtos:master Jan 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandojve nandojve nandojve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswaehn @nandojve