Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext: import ASF samv70(b) headers #23

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

iperry
Copy link

@iperry iperry commented Jun 1, 2022

I asked for some guidance in the discord channel and didn't hear back so I cargo-cult copy pasta'd what I surmise is the correct way to import these headers.

I've applied any relevant patches that I could find from the V71 tree, but I may have missed something.

This PR:

  • Imports ASF files from DFP 2.4.130
  • Applies the deprecated usart symbol patch as in e6ed079
  • Applies the XDMAC_CHID patch

I dropped the GMAC patch because the V70 doesn't have one.

Import upstream ASF support pack for the SAM V70(b).

Atmel Software Framework (ASF) provides a set of low-level header
files that give access to different hardware peripherals of Atmel's
ICs.

Origin: Atmel SAMV70(b) Series Device Support (2.4.130)
License: Apache-2.0
URL: http://packs.download.atmel.com/Atmel.SAMV70_DFP_2.4.130.atpack
Purpose: Introduction of ASF for the SAM series.
Maintained-by: External

Signed-off-by: Perry Hung <[email protected]>
Suppress deprecated macro warnings by adding the old symbols as seen in:
zephyrproject-rtos@e6ed079

Signed-off-by: Perry Hung <[email protected]>
This commit patches the incorrect XDMAC_CHID register name in the Atmel
SAMV70 DFP version 2.4.130.

Signed-off-by: Perry Hung <[email protected]>
@mbolivar-nordic
Copy link

@iperry do you have a zephyr pull request that you can use to show that this works?

see here for details on the process: https://docs.zephyrproject.org/latest/develop/modules.html#process-for-submitting-changes-to-existing-modules

This commit patches the incorrect PWM_CH_NUM register name in the Atmel
SAMV70 DFP version 2.4.130.

Signed-off-by: Perry Hung <[email protected]>
This commit patches the incorrect PWM_CMP register name in the Atmel
SAMV70 DFP version 2.4.130.
@iperry
Copy link
Author

iperry commented Jun 10, 2022

I added two more patches to address issues found as part of twister tests.

I've submitted zephyrproject-rtos/zephyr#46362 to use this, with two build targets for CI/CD.

@nandojve
Copy link
Member

Hi @iperry ,

Did you review all this list?

Patch List:
* Fix GMAC_SA register name.
* Fix XDMAC_CHID register name.
* Fix TC_CHANNEL register name.
* Fix USBHS_DEVDMA register name.
* Fix USBHS_HSTDMA register name.
* Fix MATRIX_PR register name.
* Fix PWM_CMP register name.
* Fix PWM_CH_NUM register name.
* Fix SMC_CS_NUMBER register name.
* Add old USART definitions for compatibility.

@nandojve
Copy link
Member

Hi @iperry ,

Did you review all this list?

Hi @iperry ,
I would like confirm that you reviewed all this list:

Patch List:
* Fix GMAC_SA register name.
* Fix XDMAC_CHID register name.
* Fix TC_CHANNEL register name.
* Fix USBHS_DEVDMA register name.
* Fix USBHS_HSTDMA register name.
* Fix MATRIX_PR register name.
* Fix PWM_CMP register name.
* Fix PWM_CH_NUM register name.
* Fix SMC_CS_NUMBER register name.
* Add old USART definitions for compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants