Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add color editor(srgb) #1425

Merged
merged 16 commits into from
Oct 13, 2023
Merged

add color editor(srgb) #1425

merged 16 commits into from
Oct 13, 2023

Conversation

miyanyan
Copy link
Contributor

image

9.11.1.mp4

may need:

  • icon for color picker
  • icon color combination switch

not test:

  • color picker in multi screen, maybe not work well

@zhouhang95
Copy link
Collaborator

zhouhang95 commented Sep 13, 2023 •
edited
Loading

coooooooooooooool
不要合并 我需要核查跟色彩相关的几个地方

@zhouhang95
Copy link
Collaborator

merge master 有冲突

@zhouhang95
Copy link
Collaborator

需要继续修改

@miyanyan
Copy link
Contributor Author

miyanyan commented Oct 6, 2023

现在的Color序列化是字符串形式，我暂时在MakeColor里解析的，要是序列化成vec3f就不用在MakeColor里解析了，但是不知道会影响其他的地方不

image

image

@legobadman legobadman merged commit 9e2924c into zenustech:master Oct 13, 2023
4 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legobadman legobadman legobadman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miyanyan @zhouhang95 @legobadman