Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Recovery password management on Apple Silicon #775

Merged
merged 1 commit into from
Aug 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions tests/mdm/test_api_blueprints_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from accounts.models import APIToken, User
from zentral.contrib.mdm.models import Blueprint
from zentral.core.events.base import AuditEvent
from .utils import force_blueprint, force_blueprint_artifact, force_filevault_config
from .utils import force_blueprint, force_blueprint_artifact, force_filevault_config, force_recovery_password_config


@override_settings(STATICFILES_STORAGE='django.contrib.staticfiles.storage.StaticFilesStorage')
Expand Down Expand Up @@ -97,14 +97,17 @@ def test_list_blueprints(self):
'collect_certificates': 0,
'collect_profiles': 0,
'filevault_config': None,
'recovery_password_config': None,
'created_at': blueprint.created_at.isoformat(),
'updated_at': blueprint.updated_at.isoformat()}]
)

def test_list_blueprints_name_filter(self):
force_blueprint()
filevault_config = force_filevault_config()
blueprint = force_blueprint(filevault_config=filevault_config)
recovery_password_config = force_recovery_password_config()
blueprint = force_blueprint(filevault_config=filevault_config,
recovery_password_config=recovery_password_config)
self.set_permissions("mdm.view_blueprint")
response = self.get(reverse("mdm_api:blueprints"), data={"name": blueprint.name})
self.assertEqual(response.status_code, 200)
Expand All @@ -117,6 +120,7 @@ def test_list_blueprints_name_filter(self):
'collect_certificates': 0,
'collect_profiles': 0,
'filevault_config': filevault_config.pk,
'recovery_password_config': recovery_password_config.pk,
'created_at': blueprint.created_at.isoformat(),
'updated_at': blueprint.updated_at.isoformat()}]
)
Expand Down Expand Up @@ -148,6 +152,7 @@ def test_get_blueprint(self):
'collect_certificates': 0,
'collect_profiles': 0,
'filevault_config': None,
'recovery_password_config': None,
'created_at': blueprint.created_at.isoformat(),
'updated_at': blueprint.updated_at.isoformat()}
)
Expand Down Expand Up @@ -184,6 +189,7 @@ def test_create_blueprint(self, post_event):
'collect_certificates': 0,
'collect_profiles': 0,
'filevault_config': None,
'recovery_password_config': None,
'created_at': blueprint.created_at.isoformat(),
'updated_at': blueprint.updated_at.isoformat()}
)
Expand Down Expand Up @@ -230,6 +236,7 @@ def test_update_blueprint_permission_denied(self):
def test_update_blueprint(self, post_event):
blueprint = force_blueprint()
filevault_config = force_filevault_config()
recovery_password_config = force_recovery_password_config()
prev_value = blueprint.serialize_for_event()
self.set_permissions("mdm.change_blueprint")
new_name = get_random_string(12)
Expand All @@ -240,7 +247,8 @@ def test_update_blueprint(self, post_event):
"collect_apps": 1,
"collect_certificates": 2,
"collect_profiles": 2,
"filevault_config": filevault_config.pk})
"filevault_config": filevault_config.pk,
"recovery_password_config": recovery_password_config.pk})
self.assertEqual(response.status_code, 200)
self.assertEqual(len(callbacks), 1)
blueprint.refresh_from_db()
Expand All @@ -249,6 +257,8 @@ def test_update_blueprint(self, post_event):
self.assertEqual(blueprint.collect_apps, 1)
self.assertEqual(blueprint.collect_certificates, 2)
self.assertEqual(blueprint.collect_profiles, 2)
self.assertEqual(blueprint.filevault_config, filevault_config)
self.assertEqual(blueprint.recovery_password_config, recovery_password_config)
self.assertEqual(
response.json(),
{'id': blueprint.pk,
Expand All @@ -258,6 +268,7 @@ def test_update_blueprint(self, post_event):
'collect_certificates': 2,
'collect_profiles': 2,
'filevault_config': filevault_config.pk,
'recovery_password_config': recovery_password_config.pk,
'created_at': blueprint.created_at.isoformat(),
'updated_at': blueprint.updated_at.isoformat()}
)
Expand All @@ -277,6 +288,8 @@ def test_update_blueprint(self, post_event):
"collect_certificates": 'ALL',
"collect_profiles": 'ALL',
"filevault_config": {"name": filevault_config.name, "pk": filevault_config.pk},
"recovery_password_config": {"name": recovery_password_config.name,
"pk": recovery_password_config.pk},
"created_at": blueprint.created_at,
"updated_at": blueprint.updated_at
},
Expand Down
142 changes: 142 additions & 0 deletions tests/mdm/test_api_enrolled_devices_views.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,142 @@
from functools import reduce
import operator
from unittest.mock import patch
from django.contrib.auth.models import Group, Permission
from django.db.models import Q
from django.urls import reverse
from django.utils.crypto import get_random_string
from django.test import TestCase, override_settings
from accounts.models import APIToken, User
from zentral.contrib.inventory.models import MetaBusinessUnit
from zentral.contrib.mdm.events import FileVaultPRKViewedEvent, RecoveryPasswordViewedEvent
from .utils import force_dep_enrollment_session


@override_settings(STATICFILES_STORAGE='django.contrib.staticfiles.storage.StaticFilesStorage')
class APIViewsTestCase(TestCase):
@classmethod
def setUpTestData(cls):
cls.service_account = User.objects.create(
username=get_random_string(12),
email="{}@zentral.io".format(get_random_string(12)),
is_service_account=True
)
cls.user = User.objects.create_user("godzilla", "[email protected]", get_random_string(12))
cls.group = Group.objects.create(name=get_random_string(12))
cls.service_account.groups.set([cls.group])
cls.user.groups.set([cls.group])
cls.api_key = APIToken.objects.update_or_create_for_user(cls.service_account)
cls.mbu = MetaBusinessUnit.objects.create(name=get_random_string(12))
cls.dep_enrollment_session, _, _ = force_dep_enrollment_session(
cls.mbu, authenticated=True, completed=True
)
cls.enrolled_device = cls.dep_enrollment_session.enrolled_device

# utility methods

def set_permissions(self, *permissions):
if permissions:
permission_filter = reduce(operator.or_, (
Q(content_type__app_label=app_label, codename=codename)
for app_label, codename in (
permission.split(".")
for permission in permissions
)
))
self.group.permissions.set(list(Permission.objects.filter(permission_filter)))
else:
self.group.permissions.clear()

def login(self, *permissions):
self.set_permissions(*permissions)
self.client.force_login(self.user)

def login_redirect(self, url):
response = self.client.get(url)
self.assertRedirects(response, "{u}?next={n}".format(u=reverse("login"), n=url))

def get(self, url, include_token=True):
kwargs = {}
if include_token:
kwargs["HTTP_AUTHORIZATION"] = f"Token {self.api_key}"
return self.client.get(url, **kwargs)

# enrolled_device_filevault_prk

def test_enrolled_device_filevault_prk_unauthorized(self):
response = self.get(reverse("mdm_api:enrolled_device_filevault_prk", args=(self.enrolled_device.pk,)),
include_token=False)
self.assertEqual(response.status_code, 401)

def test_enrolled_device_filevault_prk_permission_denied(self):
response = self.get(reverse("mdm_api:enrolled_device_filevault_prk", args=(self.enrolled_device.pk,)))
self.assertEqual(response.status_code, 403)

@patch("zentral.core.queues.backends.kombu.EventQueues.post_event")
def test_enrolled_device_filevault_prk_null(self, post_event):
self.set_permissions("mdm.view_filevault_prk")
response = self.get(reverse("mdm_api:enrolled_device_filevault_prk", args=(self.enrolled_device.pk,)))
self.assertEqual(
response.json(),
{"id": self.enrolled_device.pk,
"serial_number": self.enrolled_device.serial_number,
"filevault_prk": None}
)
post_event.assert_not_called()

@patch("zentral.core.queues.backends.kombu.EventQueues.post_event")
def test_enrolled_device_filevault_prk(self, post_event):
self.enrolled_device.set_filevault_prk("123456")
self.enrolled_device.save()
self.set_permissions("mdm.view_filevault_prk")
response = self.get(reverse("mdm_api:enrolled_device_filevault_prk", args=(self.enrolled_device.pk,)))
self.assertEqual(
response.json(),
{"id": self.enrolled_device.pk,
"serial_number": self.enrolled_device.serial_number,
"filevault_prk": "123456"}
)
self.assertEqual(len(post_event.call_args_list), 1)
event = post_event.call_args_list[0].args[0]
self.assertIsInstance(event, FileVaultPRKViewedEvent)
self.assertEqual(event.metadata.machine_serial_number, self.enrolled_device.serial_number)

# enrolled_device_filevault_prk

def test_enrolled_device_recovery_password_unauthorized(self):
response = self.get(reverse("mdm_api:enrolled_device_recovery_password", args=(self.enrolled_device.pk,)),
include_token=False)
self.assertEqual(response.status_code, 401)

def test_enrolled_device_recovery_password_permission_denied(self):
response = self.get(reverse("mdm_api:enrolled_device_recovery_password", args=(self.enrolled_device.pk,)))
self.assertEqual(response.status_code, 403)

@patch("zentral.core.queues.backends.kombu.EventQueues.post_event")
def test_enrolled_device_recovery_password_null(self, post_event):
self.set_permissions("mdm.view_recovery_password")
response = self.get(reverse("mdm_api:enrolled_device_recovery_password", args=(self.enrolled_device.pk,)))
self.assertEqual(
response.json(),
{"id": self.enrolled_device.pk,
"serial_number": self.enrolled_device.serial_number,
"recovery_password": None}
)
post_event.assert_not_called()

@patch("zentral.core.queues.backends.kombu.EventQueues.post_event")
def test_enrolled_device_recovery_password(self, post_event):
self.enrolled_device.set_recovery_password("123456")
self.enrolled_device.save()
self.set_permissions("mdm.view_recovery_password")
response = self.get(reverse("mdm_api:enrolled_device_recovery_password", args=(self.enrolled_device.pk,)))
self.assertEqual(
response.json(),
{"id": self.enrolled_device.pk,
"serial_number": self.enrolled_device.serial_number,
"recovery_password": "123456"}
)
self.assertEqual(len(post_event.call_args_list), 1)
event = post_event.call_args_list[0].args[0]
self.assertIsInstance(event, RecoveryPasswordViewedEvent)
self.assertEqual(event.metadata.machine_serial_number, self.enrolled_device.serial_number)
Loading