fix(cli): install proper prisma version during init #1906
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the 📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request focus on enhancing the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant CLI
participant PackageManager
User->>CLI: Initiate init command
CLI->>CLI: Check project path and Prisma schema
CLI->>CLI: Call getLatestSupportedPrismaVersion()
CLI->>PackageManager: EnsurePackage('prisma', version)
CLI->>PackageManager: EnsurePackage('@prisma/client', version)
CLI->>PackageManager: Install 'zenstack' and '@zenstackhq/runtime'
PackageManager-->>CLI: Installation complete
CLI-->>User: Initialization successful
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
⛔ Files ignored due to path filters (1)
packages/schema/src/package.jsonis excluded by!**/*.json
📒 Files selected for processing (1)
packages/schema/src/cli/actions/init.ts(3 hunks)
🔇 Additional comments (2)
packages/schema/src/cli/actions/init.ts (2)
4-4: LGTM: Import statement for package.json
The import is correctly added to access peer dependencies information.
54-57: Verify version determination behavior
The change from hardcoded 'latest' to dynamic version determination looks good, but let's verify the peer dependency specification.
✅ Verification successful
Version determination logic is correctly implemented
The implementation looks correct and well-aligned with the peer dependency specification:
getLatestSupportedPrismaVersion()correctly parses the version range from package.json's peer dependencies (5.0.0 - 6.0.x)- It properly handles both single version and range specifications
- The version is consistently applied to both
prismaand@prisma/clientpackages - The codebase has appropriate version checks against
PRISMA_MINIMUM_VERSIONin relevant places
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify prisma peer dependency specification in package.json
# Check the peer dependency specification
jq -r '.peerDependencies.prisma' packages/schema/package.json
# List all files containing prisma version references to ensure consistency
rg -l "prisma.*version|version.*prisma" --type ts
Length of output: 413
Script:
#!/bin/bash
# Let's check the implementation of getLatestSupportedPrismaVersion and its usage
ast-grep --pattern 'function getLatestSupportedPrismaVersion() {
$$$
}'
# Check the content of files that reference prisma version to understand the version handling
rg "prisma.*version|version.*prisma" -A 3 --type ts
Length of output: 3357
No description provided.