fix(delegate): nested create/connect in delegate model requires reference fields

[ymc9]

fixes #1894

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request introduces enhancements to the PrismaSchemaGenerator class in schema-generator.ts, focusing on the generation of relation fields and attributes. Key modifications include improved checks for existing foreign key fields, the introduction of a relKeyPairs variable, and refined logic for handling self-relations. Additionally, a new regression test suite is added in issue-1894.test.ts to validate the correct functionality of nested create/connect operations in delegate models, ensuring that the schema behaves as expected.

Changes

File Path	Change Summary
packages/schema/src/plugins/prisma/schema-generator.ts	Enhanced handling of relation fields and attributes, refined logic for foreign key checks, and improved inheritance handling.
tests/regression/tests/issue-1894.test.ts	Added a new test suite and test case for regression testing related to issue 1894.

Assessment against linked issues

Objective	Addressed	Explanation
Ensure nested create/connect in delegate model does not require reference fields (issue #1894)	✅

Possibly related PRs

• fix(delegate): generated logical prisma schema has errors when abstra… #1490: Refines logic for processing inherited fields from delegate models, related to relation fields and attributes.
• fix(delegate): self relation support #1821: Addresses issues with self-relations in the PrismaSchemaGenerator, enhancing relation attributes handling.
• fix: make sure both fk and relation fields are optional in create input types #1862: Ensures both foreign key and relation fields are optional in create input types, relating to the handling of relation attributes.
• fix(zod): don't include fields marked @ignore in schemas #1881: Focuses on excluding fields marked with @ignore from schemas, relevant to improvements in relation fields management.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

tests/regression/tests/issue-1894.test.ts (1)

50-50: Consider omitting explicit 'id' assignment for auto-incremented field

In await db.a.create({ data: { id: 0 } });, you're explicitly setting the id for a field defined with @id @default(autoincrement()). This may lead to conflicts or unexpected behavior. It's advisable to omit the id field and allow the database to auto-generate it.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 7fce0f0 and bad89fb.

📒 Files selected for processing (2)

• packages/schema/src/plugins/prisma/schema-generator.ts (1 hunks)
• tests/regression/tests/issue-1894.test.ts (1 hunks)

🔇 Additional comments (3)

packages/schema/src/plugins/prisma/schema-generator.ts (1)

643-685: Logic for relation attribute generation is sound

The updated logic for generating relation attributes appropriately handles foreign key fields and self-relations. The introduction of relKeyPairs and conditionally including 'fields' and 'references' in the @relation attribute enhances the accuracy of the generated Prisma schema.

tests/regression/tests/issue-1894.test.ts (2)

3-53: Regression test effectively validates the fix for issue #1894

The added test suite correctly sets up the models and verifies that nested create/connect operations in delegate models function as expected. This ensures that the regression identified in issue #1894 is resolved.

---

51-51: Verify the use of 'toResolveTruthy' in the test assertion

Ensure that toResolveTruthy is a valid matcher in your testing framework. If not, consider using a standard matcher like .resolves.toBeTruthy() to assert that the promise resolves successfully.