fix(redwood): fix incorrect error type thrown #1659
Conversation
WalkthroughWalkthroughThe updates involve renaming the error code Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- packages/misc/redwood/src/graphql.ts (2 hunks)
- packages/runtime/src/constants.ts (1 hunks)
- packages/runtime/src/enhancements/policy/policy-utils.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/runtime/src/constants.ts
Additional comments not posted (3)
packages/misc/redwood/src/graphql.ts (2)
Line range hint
49-57: LGTM! The error code correction is appropriate.The change from
CONSTRAINED_FAILEDtoCONSTRAINT_FAILEDensures that the correct error code is used for error handling.
1-1: Verify the usage ofValidationError.The
ValidationErrorimport is added, but its usage is not shown in the provided code.Run the following script to verify the usage of
ValidationErrorin the codebase:Verification successful
ValidationError is used in the codebase.
The
ValidationErrorimport is correctly utilized in the filepackages/misc/redwood/src/graphql.ts.
packages/misc/redwood/src/graphql.ts:return new ValidationError(error.message);Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of `ValidationError` in the codebase. # Test: Search for the usage of `ValidationError`. Expect: At least one occurrence. rg --type javascript 'ValidationError'Length of output: 73
Script:
#!/bin/bash # Description: Verify the usage of `ValidationError` in the codebase. # Test: Search for the usage of `ValidationError`. Expect: At least one occurrence. rg --type ts 'ValidationError'Length of output: 9074
packages/runtime/src/enhancements/policy/policy-utils.ts (1)
1218-1218: LGTM! The error code correction is appropriate.The change from
CONSTRAINED_FAILEDtoCONSTRAINT_FAILEDensures that the correct error code is used for error handling.
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/server/src/api/rest/index.ts (1 hunks)
- packages/server/src/api/rpc/index.ts (1 hunks)
Additional comments not posted (2)
packages/server/src/api/rpc/index.ts (1)
21-21: LGTM! Correct error code for accurate error handling.The change from
PrismaErrorCode.CONSTRAINED_FAILEDtoPrismaErrorCode.CONSTRAINT_FAILEDensures that the correct error code is used for mapping to HTTP status 403.packages/server/src/api/rest/index.ts (1)
1592-1592: LGTM! Correct error code for accurate error handling.The change from
PrismaErrorCode.CONSTRAINED_FAILEDtoPrismaErrorCode.CONSTRAINT_FAILEDensures that the correct error code is checked for handling Prisma client errors.
No description provided.