fix: createManyAndReturn doesn't work for polymorphic models

[ymc9]

Fixes #1576

[coderabbitai]

Walkthrough

Walkthrough

Recent updates to the DelegateProxyHandler and PolicyProxyHandler classes in the runtime package focus on enhancing the createManyAndReturn method. This method now handles delegate models more effectively by checking conditions and converting operations when necessary, while returning an array of results. Additionally, the new method signature has been integrated into several test cases to ensure proper functionality.

Changes

File Path	Change Summary
packages/runtime/src/enhancements/delegate.ts	Updated DelegateProxyHandler class to modify createManyAndReturn method for better handling of delegate models and returning arrays of results.
packages/runtime/src/enhancements/policy/handler.ts	Modified PolicyProxyHandler class by updating createManyAndReturn method signature to change parameter order and remove include parameter.
packages/runtime/src/enhancements/proxy.ts	Updated PrismaProxyHandler interface and DefaultPrismaProxyHandler class by modifying createManyAndReturn method to remove the include parameter and make the select parameter optional.
tests/integration/tests/enhancements/with-delegate/enhanced-client.test.ts	Added test cases for createManyAndReturn method to verify the creation of multiple rated videos with specific attributes and relationships.
tests/regression/tests/issue-1576.test.ts	Introduced a new test case for issue #1576, focusing on schema loading and data creation in a database, including the creation of profiles and items with polymorphic relationships.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Argument ID is missing from createManyAndReturn API (#1576)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6439fd6 and 43b90f7.

Files selected for processing (5)

• packages/runtime/src/enhancements/delegate.ts (1 hunks)
• packages/runtime/src/enhancements/policy/handler.ts (1 hunks)
• packages/runtime/src/enhancements/proxy.ts (2 hunks)
• tests/integration/tests/enhancements/with-delegate/enhanced-client.test.ts (2 hunks)
• tests/regression/tests/issue-1576.test.ts (1 hunks)

Additional comments not posted (14)

tests/regression/tests/issue-1576.test.ts (1)

1-63: Well-structured regression test case.

The test case is comprehensive and ensures that the createManyAndReturn function works correctly for polymorphic models. It covers the creation of GoldProfile and GoldItem instances and verifies the expected results.

packages/runtime/src/enhancements/proxy.ts (2)

38-38: Interface updated correctly.

The createManyAndReturn method has been added to the PrismaProxyHandler interface with the specified signature.

---

127-127: Method implementation is consistent.

The createManyAndReturn method has been implemented in the DefaultPrismaProxyHandler class using a deferred promise. The implementation is consistent with the existing methods in the class.

packages/runtime/src/enhancements/delegate.ts (2)

374-374: Method signature added correctly.

The createManyAndReturn method signature has been added to the DelegateProxyHandler class.

---

375-409: Thorough method implementation.

The createManyAndReturn method implementation includes necessary validation checks and uses a transaction to handle the creation of multiple instances. The method ensures that the operation is performed correctly for polymorphic models.

tests/integration/tests/enhancements/with-delegate/enhanced-client.test.ts (3)

132-145: LGTM!

The test case for createManyAndReturn method correctly verifies the creation of a single ratedVideo instance and checks the returned array for expected properties.

---

157-169: LGTM!

The test case for createManyAndReturn method correctly verifies the creation of multiple ratedVideo instances and checks the returned array for expected properties and selected fields.

---

187-187: LGTM!

The test case for createMany method correctly verifies the creation of multiple user instances with polymorphic relations and checks the returned result for the expected count.

packages/runtime/src/enhancements/policy/handler.ts (6)

464-466: Validate arguments before proceeding.

Ensure that the args and args.data are validated before proceeding with the method logic.

---

Line range hint 468-470: Ensure safe cloning of arguments.

The args should be safely cloned to avoid unintended side effects.

---

Line range hint 472-474: Check for post-create validation.

The validateCreateInput method is used to determine if post-create validation is needed.

---

Line range hint 476-479: Handle direct creation.

If no post-create validation is needed, handle the direct creation of entities.

---

Line range hint 481-486: Handle creation with transaction.

If post-create validation is needed, handle the creation within a transaction and perform post-create checks.

---

Line range hint 488-492: Handle read-back errors.

Ensure that any errors during the read-back process are properly handled and thrown.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 43b90f7 and 135ac76.

Files selected for processing (1)

• tests/integration/tests/enhancements/with-delegate/enhanced-client.test.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

• tests/integration/tests/enhancements/with-delegate/enhanced-client.test.ts