-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: incorrect typing when Prisma client extension is used with logical client #1557
Conversation
WalkthroughThe changes enhance the Changes
Sequence Diagram(s)No sequence diagrams are needed as the changes do not introduce new features significantly altering control flow. Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/schema/src/plugins/enhancer/enhance/index.ts (1 hunks)
- tests/regression/tests/issue-1493.test.ts (1 hunks)
Additional comments not posted (2)
tests/regression/tests/issue-1493.test.ts (1)
1-66
: LGTM!The test case is well-structured and covers the issue described in #1493. The schema and client configurations are correctly set up to reproduce the issue.
packages/schema/src/plugins/enhancer/enhance/index.ts (1)
176-180
: LGTM!The changes enhance type safety and flexibility. The function signature adjustments are correctly implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/schema/src/plugins/enhancer/enhance/index.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/schema/src/plugins/enhancer/enhance/index.ts
Fixes #1493