-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: issue a warning if "generateClient" is set to false in the prisma plugin #1555
Conversation
WalkthroughWalkthroughThe changes improve the logging functionality within the Prisma plugin of a schema package. Specifically, they add the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant PrismaPlugin
participant colors
User->>PrismaPlugin: Trigger schema generation
PrismaPlugin->>colors: Import colors package
alt generateClient is false
PrismaPlugin->>User: Log colored warning: "Skipping Prisma client generation"
end
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
packages/schema/src/plugins/prisma/index.ts (1)
64-69
: Warning message for skipping Prisma client generation is correctly added.The warning message correctly notifies when Prisma client generation is skipped due to the "generateClient" flag being set to false. However, it can be improved for clarity.
- 'Skipping prisma client generation because "generateClient" is set to false. This may break plugins that depend on the prisma client.' + 'Warning: Skipping Prisma client generation because the "generateClient" flag is set to false. This may break plugins that depend on the Prisma client.'
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/schema/src/plugins/prisma/index.ts (2 hunks)
Additional comments not posted (1)
packages/schema/src/plugins/prisma/index.ts (1)
11-11
: Import statement forcolors
is correctly added.The import statement for
colors
is correctly added to enhance console color output.
No description provided.