-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused dependency promisify
#1534
Conversation
This removes the `promisify` dependency which is unused. This dependency itself depends on `"when": ""`, which, not declaring a version, breaks certain package managers like Bun.
WalkthroughWalkthroughThis update focuses on pinning the versions for Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Thanks for making the change @benjamintd ! It looks good to me and I'll merge once the CI passes. |
Thank you @ymc9 for updating the lockfile. I made the edit in the Github UI after checking that the dependency was unused, but did not get to installing the project on my machine to do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
packages/schema/package.json
is excluded by!**/*.json
packages/sdk/package.json
is excluded by!**/*.json
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
,!**/*.yaml
tests/integration/test-run/package.json
is excluded by!**/*.json
tests/integration/tests/frameworks/nextjs/test-project/package.json
is excluded by!**/*.json
tests/integration/tests/frameworks/trpc/test-project/package.json
is excluded by!**/*.json
Files selected for processing (2)
- script/test-scaffold.ts (1 hunks)
- tests/integration/tests/cli/plugins.test.ts (2 hunks)
Files skipped from review due to trivial changes (2)
- script/test-scaffold.ts
- tests/integration/tests/cli/plugins.test.ts
No worries. I've also found another issue caused by not pinning Prisma dependency's minor version. Prisma 5.16 introduced a breaking change. |
This removes the
promisify
dependency which is unused.This dependency itself depends on
"when": ""
, which, not declaring a version, breaks certain package managers like Bun.