fix(delegate): make sure nested createMany is converted into regular create
#1526
Conversation
…r `create` Fixes #1520
WalkthroughWalkthroughThe changes improve the Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (2)
packages/runtime/src/enhancements/delegate.ts (2)
Line range hint
286-292: Theelseclause here can be omitted as the previous branches already usebreak, making theelseredundant and potentially misleading.- else { + // removed unnecessary else clause
Line range hint
979-979: Consider using optional chaining here to improve code readability and safety.- if (subData && typeof subData === 'object') { + if (subData?.typeof === 'object') {
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- packages/runtime/src/enhancements/delegate.ts (2 hunks)
- tests/regression/tests/issue-1520.test.ts (1 hunks)
Additional context used
Biome
packages/runtime/src/enhancements/delegate.ts
[error] 92-94: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 132-135: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 170-173: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 286-292: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 307-307: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 330-330: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 455-455: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 672-703: This else clause can be omitted because previous branches break early. (lint/style/noUselessElse)
Unsafe fix: Omit the else clause.
[error] 736-736: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 799-799: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 807-807: Avoid the delete operator which can impact performance. (lint/performance/noDelete)
Unsafe fix: Use an undefined assignment instead.
[error] 979-979: Change to an optional chain. (lint/complexity/useOptionalChain)
Unsafe fix: Change to an optional chain.
Additional comments not posted (2)
tests/regression/tests/issue-1520.test.ts (1)
1-70: The test case is well-structured and effectively simulates the scenario described in the linked issue. It correctly sets up the schema, performs the operation that was previously causing the error, and asserts the expected behavior. The usage ofcreateManyin the test setup corresponds well with the PR's objective to handle such cases correctly.packages/runtime/src/enhancements/delegate.ts (1)
393-397: The conversion fromcreateManytocreateis implemented to handle nested creation scenarios wherecreateManyis not applicable. This is crucial for maintaining data integrity and consistency, especially in models that inherit a delegate base. Ensure thorough testing to validate that this conversion does not introduce any side effects or performance issues.[APROVED]
Fixes #1520