-
-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade to Prisma 5.14.0 #1477
Conversation
Important Review skippedReview was skipped due to path filters Files ignored due to path filters (2)
You can disable this status message by setting the WalkthroughThe recent changes primarily focus on refining the test cases within the schema package. Specifically, the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
packages/schema/tests/generator/prisma-generator.test.ts (3)
Line range hint
4-4
: Update import statement to use thenode:
protocol for built-in modules.- import fs from 'fs'; + import fs from 'node:fs';
Line range hint
5-5
: Update import statement to use thenode:
protocol for built-in modules.- import path from 'path'; + import path from 'node:path';
Line range hint
211-211
: Avoid using template literals when not necessary.- expect(content).toContain( - '/// Admin role documentation line 1\n' + ' /// Admin role documentation line 2\n' + ' ADMIN' - ); + expect(content).toContain('/// Admin role documentation line 1\n /// Admin role documentation line 2\n ADMIN');
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (6)
packages/schema/package.json
is excluded by!**/*.json
packages/sdk/package.json
is excluded by!**/*.json
pnpm-lock.yaml
is excluded by!pnpm-lock.yaml
,!**/*.yaml
tests/integration/test-run/package.json
is excluded by!**/*.json
tests/integration/tests/frameworks/nextjs/test-project/package.json
is excluded by!**/*.json
tests/integration/tests/frameworks/trpc/test-project/package.json
is excluded by!**/*.json
Files selected for processing (2)
- packages/schema/tests/generator/prisma-generator.test.ts (3 hunks)
- packages/schema/tests/schema/validation/datasource-validation.test.ts (4 hunks)
Files skipped from review due to trivial changes (1)
- packages/schema/tests/schema/validation/datasource-validation.test.ts
Additional context used
Biome
packages/schema/tests/generator/prisma-generator.test.ts
[error] 4-4: A Node.js builtin module should be imported with the node: protocol.
[error] 5-5: A Node.js builtin module should be imported with the node: protocol.
[error] 211-211: Do not use template literals if interpolation and special-character handling are not needed.
Fixes #1478 |
No description provided.