Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Prisma 5.14.0 #1477

Merged
merged 3 commits into from
Jun 2, 2024
Merged

chore: upgrade to Prisma 5.14.0 #1477

merged 3 commits into from
Jun 2, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented Jun 2, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Jun 2, 2024

Important

Review skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • packages/runtime/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml, !**/*.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent changes primarily focus on refining the test cases within the schema package. Specifically, the prisma-generator.test.ts file saw the removal of the shadowDatabaseUrl declaration and some formatting adjustments. Meanwhile, the datasource-validation.test.ts file experienced modifications to error message structures and the elimination of certain error checks related to field values. No public or exported entity declarations were altered in this update.

Changes

File Path Change Summary
packages/schema/tests/generator/prisma-generator.test.ts Removed shadowDatabaseUrl declaration and adjusted code block formatting.
packages/schema/tests/schema/validation/datasource-validation.test.ts Adjusted error message structures and removed specific error checks.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range and nitpick comments (3)
packages/schema/tests/generator/prisma-generator.test.ts (3)

Line range hint 4-4: Update import statement to use the node: protocol for built-in modules.

- import fs from 'fs';
+ import fs from 'node:fs';

Line range hint 5-5: Update import statement to use the node: protocol for built-in modules.

- import path from 'path';
+ import path from 'node:path';

Line range hint 211-211: Avoid using template literals when not necessary.

- expect(content).toContain(
-     '/// Admin role documentation line 1\n' + '  /// Admin role documentation line 2\n' + '  ADMIN'
- );
+ expect(content).toContain('/// Admin role documentation line 1\n  /// Admin role documentation line 2\n  ADMIN');
Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6610bd0 and 76059e3.

Files ignored due to path filters (6)
  • packages/schema/package.json is excluded by !**/*.json
  • packages/sdk/package.json is excluded by !**/*.json
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml, !**/*.yaml
  • tests/integration/test-run/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/nextjs/test-project/package.json is excluded by !**/*.json
  • tests/integration/tests/frameworks/trpc/test-project/package.json is excluded by !**/*.json
Files selected for processing (2)
  • packages/schema/tests/generator/prisma-generator.test.ts (3 hunks)
  • packages/schema/tests/schema/validation/datasource-validation.test.ts (4 hunks)
Files skipped from review due to trivial changes (1)
  • packages/schema/tests/schema/validation/datasource-validation.test.ts
Additional context used
Biome
packages/schema/tests/generator/prisma-generator.test.ts

[error] 4-4: A Node.js builtin module should be imported with the node: protocol.


[error] 5-5: A Node.js builtin module should be imported with the node: protocol.


[error] 211-211: Do not use template literals if interpolation and special-character handling are not needed.

@ymc9
Copy link
Member Author

ymc9 commented Jun 2, 2024

Fixes #1478

@ymc9 ymc9 merged commit f606b12 into dev Jun 2, 2024
13 checks passed
@ymc9 ymc9 deleted the chore/prisma-5.14.0 branch June 2, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant