fix: infinite recursion when injecting field selection for field-level permission check

[ymc9]

Fixes #1451

[coderabbitai]

Walkthrough

This update addresses a version increment for the JetBrains IDE plugin, an enhancement to the injectReadCheckSelect method in the PolicyUtil class to prevent infinite recursion, and the addition of a regression test for issue 1451 related to schema loading and data manipulation using Prisma ORM.

Changes

File Path	Change Summary
packages/ide/jetbrains/build.gradle.kts	Updated version from 2.1.0 to 2.1.1 within the dev.zenstack group.
packages/runtime/src/enhancements/policy/...	Modified injectReadCheckSelect method to recurse into relation fields before injecting the current level.
tests/regression/tests/issue-1451.test.ts	Introduced a new test case to verify the fix for issue 1451 related to schema loading and data manipulation using Prisma ORM.

Assessment against linked issues

Objective	Addressed	Explanation
Fix the "Maximum call stack size exceeded" error when calling /api/model/membership/findMany (#1451)	✅
Ensure field-level access policies are correctly applied without causing recursion issues (#1451)	✅
Validate the fix through a regression test for issue 1451 (#1451)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4cbfe8d and 5441665.

Files ignored due to path filters (14)

• package.json is excluded by !**/*.json
• packages/ide/jetbrains/package.json is excluded by !**/*.json
• packages/language/package.json is excluded by !**/*.json
• packages/misc/redwood/package.json is excluded by !**/*.json
• packages/plugins/openapi/package.json is excluded by !**/*.json
• packages/plugins/swr/package.json is excluded by !**/*.json
• packages/plugins/tanstack-query/package.json is excluded by !**/*.json
• packages/plugins/trpc/package.json is excluded by !**/*.json
• packages/plugins/trpc/tests/projects/t3-trpc-v10/package.json is excluded by !**/*.json
• packages/runtime/package.json is excluded by !**/*.json
• packages/schema/package.json is excluded by !**/*.json
• packages/sdk/package.json is excluded by !**/*.json
• packages/server/package.json is excluded by !**/*.json
• packages/testtools/package.json is excluded by !**/*.json

Files selected for processing (3)

• packages/ide/jetbrains/build.gradle.kts (1 hunks)
• packages/runtime/src/enhancements/policy/policy-utils.ts (2 hunks)
• tests/regression/tests/issue-1451.test.ts (1 hunks)

Files skipped from review due to trivial changes (2)

• packages/ide/jetbrains/build.gradle.kts
• tests/regression/tests/issue-1451.test.ts

Additional comments not posted (2)

packages/runtime/src/enhancements/policy/policy-utils.ts (2)

963-965: Avoid infinite recursion by recursing into relation fields first.

This change ensures that relation fields are processed before injecting the current level, preventing potential infinite recursion issues. This is a good fix for the problem described in the PR objectives.

---

975-981: Ensure field-level policy checks are injected correctly.

The logic to inject field-level read checks after processing relation fields is sound. This ensures that the necessary field-level policies are applied without causing recursion issues.