Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid importing prisma-related code into language server #1441

Merged
merged 1 commit into from
May 12, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented May 12, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented May 12, 2024

Walkthrough

Walkthrough

The recent updates primarily revolve around the redistribution of the supportCreateMany function across various modules in the SDK. The function has been moved from a general import to a more specific one under @zenstackhq/sdk/prisma. Additionally, there are some import reorganizations and removals in utility functions, enhancing modularity and perhaps aligning with updated dependencies or architectural optimizations.

Changes

File Path Change Summary
.../openapi/src/rpc-generator.ts
.../swr/src/generator.ts
.../trpc/src/generator.ts
Moved supportCreateMany from @zenstackhq/sdk to @zenstackhq/sdk/prisma.
.../tanstack-query/src/generator.ts
.../schema/src/plugins/zod/generator.ts
Removed supportCreateMany import.
.../schema/src/plugins/zod/transformer.ts Reordered imports, adjusted supportCreateMany and PrismaDMMF imports.
.../sdk/src/prisma.ts Added semver, Model, getDataSourceProvider imports; added supportCreateMany function.
.../sdk/src/utils.ts Removed semver and getPrismaVersion imports; removed related logic in supportCreateMany.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a49b7b3 and a638274.
Files selected for processing (8)
  • packages/plugins/openapi/src/rpc-generator.ts (2 hunks)
  • packages/plugins/swr/src/generator.ts (1 hunks)
  • packages/plugins/tanstack-query/src/generator.ts (1 hunks)
  • packages/plugins/trpc/src/generator.ts (1 hunks)
  • packages/schema/src/plugins/zod/generator.ts (1 hunks)
  • packages/schema/src/plugins/zod/transformer.ts (1 hunks)
  • packages/sdk/src/prisma.ts (2 hunks)
  • packages/sdk/src/utils.ts (2 hunks)
Files skipped from review due to trivial changes (5)
  • packages/plugins/openapi/src/rpc-generator.ts
  • packages/plugins/swr/src/generator.ts
  • packages/schema/src/plugins/zod/generator.ts
  • packages/schema/src/plugins/zod/transformer.ts
  • packages/sdk/src/utils.ts
Additional comments not posted (4)
packages/sdk/src/prisma.ts (2)

11-11: The addition of getDataSourceProvider import is appropriate for the new functionality in supportCreateMany.


84-89: The implementation of supportCreateMany function is correct and uses the newly added imports effectively.

packages/plugins/trpc/src/generator.ts (1)

13-13: The change in import for supportCreateMany from @zenstackhq/sdk to @zenstackhq/sdk/prisma is aligned with the PR's objectives to better manage Prisma-related dependencies.

packages/plugins/tanstack-query/src/generator.ts (1)

14-14: The change in import for supportCreateMany from @zenstackhq/sdk to @zenstackhq/sdk/prisma is aligned with the PR's objectives to better manage Prisma-related dependencies.

@ymc9 ymc9 merged commit b22c6a3 into dev May 12, 2024
13 checks passed
@ymc9 ymc9 deleted the fix/avoid-import-prisma branch May 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant