-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: avoid importing prisma-related code into language server #1441
Conversation
WalkthroughWalkthroughThe recent updates primarily revolve around the redistribution of the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- packages/plugins/openapi/src/rpc-generator.ts (2 hunks)
- packages/plugins/swr/src/generator.ts (1 hunks)
- packages/plugins/tanstack-query/src/generator.ts (1 hunks)
- packages/plugins/trpc/src/generator.ts (1 hunks)
- packages/schema/src/plugins/zod/generator.ts (1 hunks)
- packages/schema/src/plugins/zod/transformer.ts (1 hunks)
- packages/sdk/src/prisma.ts (2 hunks)
- packages/sdk/src/utils.ts (2 hunks)
Files skipped from review due to trivial changes (5)
- packages/plugins/openapi/src/rpc-generator.ts
- packages/plugins/swr/src/generator.ts
- packages/schema/src/plugins/zod/generator.ts
- packages/schema/src/plugins/zod/transformer.ts
- packages/sdk/src/utils.ts
Additional comments not posted (4)
packages/sdk/src/prisma.ts (2)
11-11
: The addition ofgetDataSourceProvider
import is appropriate for the new functionality insupportCreateMany
.
84-89
: The implementation ofsupportCreateMany
function is correct and uses the newly added imports effectively.packages/plugins/trpc/src/generator.ts (1)
13-13
: The change in import forsupportCreateMany
from@zenstackhq/sdk
to@zenstackhq/sdk/prisma
is aligned with the PR's objectives to better manage Prisma-related dependencies.packages/plugins/tanstack-query/src/generator.ts (1)
14-14
: The change in import forsupportCreateMany
from@zenstackhq/sdk
to@zenstackhq/sdk/prisma
is aligned with the PR's objectives to better manage Prisma-related dependencies.
No description provided.