Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main (v2.0.1) #1384

Merged
merged 7 commits into from
Apr 26, 2024
Merged

merge dev to main (v2.0.1) #1384

merged 7 commits into from
Apr 26, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented Apr 25, 2024

Summary by CodeRabbit

  • Documentation

    • Updated the README with new links related to NestJS Backend API and Polymorphic Relations.
    • Updated the changelog for JetBrains IDE plugin with a note on ZenStack V2 release.
    • Updated versions of ZenStack and Prisma in the bug report template.
  • New Features

    • Added a new integration test case for deep-nested post-update scenarios in policy enforcement.
  • Bug Fixes

    • Improved the logic for resolving transitive imports in schema utilities to handle URIs case-insensitively.
  • Refactor

    • Enhanced method for checking future member access in expression writing.
  • Tests

    • Added a regression test for issue 1381 to ensure correct schema loading and authorization rules application.

Copy link
Contributor

coderabbitai bot commented Apr 25, 2024

Walkthrough

Walkthrough

The latest changes encompass a broad spectrum of improvements to the software. Highlights include the addition of new links and updated content in the README, version upgrades in JetBrains IDE plugins, and advancements in schema management and policy enforcement capabilities. Furthermore, new test cases have been introduced to validate the functionality of nested policy updates and schema loading processes.

Changes

File Path Change Summary
README.md Added link to "NestJS Backend API", updated architecture overview with "Polymorphic Relations", removed "Polymorphism (future)".
packages/ide/jetbrains/CHANGELOG.md Updated JetBrains plugin version from 1.7.0 to 1.11.0. Noted ZenStack V2 release.
packages/ide/jetbrains/build.gradle.kts Updated JetBrains IDE plugin version from "2.0.0" to "2.0.1".
packages/schema/src/language-server/zmodel-code-action.ts Modified position assignment in ZModelCodeActionProvider to use targetDocument instead of document.
packages/schema/src/plugins/enhancer/policy/expression-writer.ts Enhanced isFutureMemberAccess method in ExpressionWriter to recursively check for future member access expressions.
packages/schema/src/utils/ast-utils.ts Enhanced resolveTransitiveImportsInternal function to improve handling of URIs during import resolution.
tests/integration/tests/enhancements/with-policy/post-update.test.ts Added a test case for deep-nested updates in policies within the With Policy context.
tests/regression/tests/issue-1381.test.ts Added a test case for issue 1381 related to schema loading and authorization rules.
.github/ISSUE_TEMPLATE/bug_report.md Updated ZenStack and Prisma versions to 2.0.0 and 5.7.0 respectively.
.github/workflows/build-test.yml Modified event triggers for workflow execution, removing branch triggers for pushes and adjusting content access permissions.
.github/workflows/codeql.yml Revised triggers for push events and schedule, focusing on pull requests and a weekly schedule.
.github/workflows/integration-test.yml Adjusted event configuration by removing specific branch triggers for push events.
.github/workflows/regression-test.yml Updated event triggers for pull requests, removing specific branch triggers for push events.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between 08471d5 and 7a15948.
Files selected for processing (5)
  • .github/ISSUE_TEMPLATE/bug_report.md (1 hunks)
  • .github/workflows/build-test.yml (1 hunks)
  • .github/workflows/codeql.yml (1 hunks)
  • .github/workflows/integration-test.yml (1 hunks)
  • .github/workflows/regression-test.yml (1 hunks)
Files skipped from review due to trivial changes (3)
  • .github/workflows/codeql.yml
  • .github/workflows/integration-test.yml
  • .github/workflows/regression-test.yml
Additional Context Used
LanguageTool (3)
.github/ISSUE_TEMPLATE/bug_report.md (3)

Near line 17: Possible spelling mistake found.
Context: ...lete the following information):** - ZenStack version: [e.g., 2.0.0] - Prisma versi...


Near line 18: Possible spelling mistake found.
Context: ...- ZenStack version: [e.g., 2.0.0] - Prisma version: [e.g., 5.7.0] - Database type: [e.g....


Near line 19: Possible spelling mistake found.
Context: ... [e.g., 5.7.0] - Database type: [e.g. Postgresql] Additional context Add any other ...

Additional comments not posted (16)
.github/ISSUE_TEMPLATE/bug_report.md (1)

17-17: Update the ZenStack version to reflect the new release.

.github/workflows/build-test.yml (15)

17-17: Ensure the TELEMETRY_TRACKING_TOKEN is securely handled and not exposed in logs.


18-18: Setting DO_NOT_TRACK is a good practice for privacy compliance.


Line range hint 19-19: Validate that the branch triggers for pull requests are correctly configured to include all necessary branches.


Line range hint 20-20: Check that the contents: read permission is sufficient for all operations in this workflow.


Line range hint 21-21: Review the configuration of the PostgreSQL service to ensure it meets security best practices, especially the password.


Line range hint 22-22: Confirm the health check settings for PostgreSQL are optimal for the expected workload.


Line range hint 23-23: Ensure the node version specified in the matrix is compatible with all dependencies.


Line range hint 24-24: Check the caching strategy for pnpm to ensure it is efficient and effective.


Line range hint 25-25: Validate the Gradle Wrapper Validation step to ensure it is correctly configured and necessary.


Line range hint 26-26: Ensure the Java setup step is aligned with the project requirements.


Line range hint 27-27: Review the Gradle setup to confirm it is optimized for the project's build process.


Line range hint 28-28: Ensure the build step is correctly configured to use the appropriate npm tag.


Line range hint 29-29: Review the lint step to ensure it covers all relevant code paths and adheres to the project's coding standards.


Line range hint 30-30: Confirm that the internal dependencies are correctly managed and that the installation step is necessary.


Line range hint 31-31: Ensure the test steps are comprehensive and cover all critical paths.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Out of diff range and nitpick comments (1)
packages/ide/jetbrains/CHANGELOG.md (1)

5-5: Ensure the spelling of "ZenStack V2 release!" is consistent with branding guidelines.

packages/ide/jetbrains/CHANGELOG.md Show resolved Hide resolved
@ymc9 ymc9 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit 3291c6e Apr 26, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants