fix(vscode): more robustly handle VSCode document URI

[ymc9]

Summary by CodeRabbit

• Bug Fixes
  • Improved URI comparison and normalization to enhance the accuracy of tracking visited URIs in the system.

[coderabbitai]

Walkthrough

Walkthrough

The recent update in the codebase includes modifications to the resolveTransitiveImportsInternal function within ast-utils.ts. The primary enhancement involves handling URIs in a case-insensitive manner and normalizing paths for URIs that have been visited. This adjustment improves the accuracy and efficiency of tracking visited URIs in the import resolution process.

Changes

File	Summary of Changes
packages/.../ast-utils.ts	Updated the resolveTransitiveImportsInternal function to compare URIs case-insensitively and use normalized paths for tracking visited URIs.

---

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between da0bbd1 and 5e45574.

Files selected for processing (1)

• packages/schema/src/utils/ast-utils.ts (1 hunks)

Additional comments not posted (3)

packages/schema/src/utils/ast-utils.ts (3)

184-184: Ensure initialization of visited set is clear in documentation.

It's important to document that the visited set now expects URIs in a normalized, lower-case format due to the changes in URI handling.

---

190-190: Good use of case-insensitive comparison for URI paths.

This change ensures that URI comparison is robust across different operating systems and file systems, aligning with the PR's objectives.

---

194-196: Proper implementation of URI normalization and tracking.

The normalization of the URI path before checking and adding to the visited set is a crucial improvement for consistent URI handling.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.