Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: stricter Prisma peer dependencies #1234

Merged
merged 1 commit into from
Apr 10, 2024
Merged

chore: stricter Prisma peer dependencies #1234

merged 1 commit into from
Apr 10, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented Apr 10, 2024

No description provided.

Copy link
Contributor

coderabbitai bot commented Apr 10, 2024

Walkthrough

Walkthrough

The recent updates primarily focus on standardizing the versions of @prisma/client and prisma across various packages and test projects to 5.12.0 from earlier versions. This change ensures compatibility and stability with the specified version range of 5.0.0 - 5.12.x. Additionally, there's an update to the react version in one of the test projects to ^18.2.0.

Changes

File Path Change Summary
packages/runtime/package.json Updated @prisma/client peer dependency from ^5.0.0 to 5.0.0 - 5.12.x.
packages/schema/package.json Updated prisma in both peerDependencies and devDependencies to 5.0.0 - 5.12.x and 5.12.0 respectively.
tests/integration/.../test-run/package.json Set @prisma/client and prisma to 5.12.0; updated react to ^18.2.0.
tests/integration/.../nextjs/test-project/package.json
tests/integration/.../trpc/test-project/package.json
Standardized @prisma/client and prisma to 5.12.0 in both test projects.

Recent Review Details

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between f04824e and 8aba578.
Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !pnpm-lock.yaml
Files selected for processing (5)
  • packages/runtime/package.json (1 hunks)
  • packages/schema/package.json (2 hunks)
  • tests/integration/test-run/package.json (1 hunks)
  • tests/integration/tests/frameworks/nextjs/test-project/package.json (2 hunks)
  • tests/integration/tests/frameworks/trpc/test-project/package.json (2 hunks)
Files skipped from review due to trivial changes (1)
  • tests/integration/tests/frameworks/trpc/test-project/package.json
Additional comments not posted (8)
tests/integration/tests/frameworks/nextjs/test-project/package.json (2)

12-12: Version pinning of @prisma/client to 5.12.0 aligns with the PR's goal to ensure compatibility by narrowing dependency versions.


25-25: Pinning prisma to 5.12.0 in devDependencies is a prudent choice to maintain consistent development environments.

tests/integration/test-run/package.json (3)

13-13: Version update of @prisma/client to 5.12.0 is consistent with the PR's objectives to stabilize dependency versions.


15-15: Updating prisma to 5.12.0 helps ensure consistency across the project's dependencies.


15-15: The update of react to ^18.2.0 is a beneficial side change, likely improving compatibility or features with newer versions.

packages/runtime/package.json (1)

82-82: Narrowing the version range of @prisma/client in peerDependencies to 5.0.0 - 5.12.x aligns with the PR's goal to ensure compatibility.

packages/schema/package.json (2)

114-114: Adjusting the prisma version range in peerDependencies to 5.0.0 - 5.12.x helps ensure greater compatibility and stability.


129-129: Pinning prisma to 5.12.0 in devDependencies ensures a stable development environment.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ymc9 ymc9 merged commit 482912b into v2 Apr 10, 2024
12 checks passed
@ymc9 ymc9 deleted the chore/strict-peer-dep branch April 10, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant