Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix @db.Uuid (corrected) #1207

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix @db.Uuid (corrected) #1207

merged 2 commits into from
Apr 2, 2024

Conversation

sakgoyal
Copy link
Contributor

@sakgoyal sakgoyal commented Apr 2, 2024

Summary by CodeRabbit

  • New Features
    • Added support for generating UUID schema, enhancing data modeling capabilities.

Copy link
Contributor

coderabbitai bot commented Apr 2, 2024

Walkthrough

Walkthrough

The update enhances the schema generation capability by adding support for generating UUID schemas in the makeFieldSchema function. This improvement expands the functionality of schema generation to include UUID support, catering to applications that require UUIDs for various purposes.

Changes

File(s) Summary of Changes
packages/schema/src/plugins/zod/utils/schema-gen.ts Added support for generating UUID schema in the makeFieldSchema function.
tests/integration/tests/plugins/zod.test.ts Added import of randomUUID from 'crypto' and introduced a new field r of type String with a constraint @db.Uuid in the Zod schema definition. Tests added to validate the new field behavior.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sakgoyal
Copy link
Contributor Author

sakgoyal commented Apr 2, 2024

#1196

@sakgoyal sakgoyal marked this pull request as ready for review April 2, 2024 03:29
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between a0ce485 and c98c758.
Files selected for processing (1)
  • packages/schema/src/plugins/zod/utils/schema-gen.ts (1 hunks)
Additional Context Used
Additional comments not posted (1)
packages/schema/src/plugins/zod/utils/schema-gen.ts (1)

105-108: The addition of UUID support with .uuid() is correctly implemented and follows the established pattern for schema generation. Ensure comprehensive testing, especially for edge cases and invalid UUID formats, to maintain data integrity.

@ymc9
Copy link
Member

ymc9 commented Apr 2, 2024

Thank you @sakgoyal ! I'll merge it when CI passes.

ymc9
ymc9 previously approved these changes Apr 2, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review Status

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between c98c758 and 9b3111b.
Files selected for processing (1)
  • tests/integration/tests/plugins/zod.test.ts (3 hunks)
Additional comments not posted (2)
tests/integration/tests/plugins/zod.test.ts (2)

5-5: The import of randomUUID from 'crypto' is correctly added to support UUID generation in tests.


297-305: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [239-302]

The introduction of the new field r of type String with a constraint @db.Uuid and the tests validating its behavior are correctly implemented.

@ymc9 ymc9 merged commit 7d2114f into zenstackhq:dev Apr 2, 2024
3 checks passed
@sakgoyal sakgoyal deleted the patch-1 branch April 5, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants