-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dev to main (v1.11.0) #1146
Conversation
WalkthroughWalkthroughThis update brings enhancements across various packages, including the JetBrains IDE plugin, schema utilities, and the SDK. Key improvements include the version bump of the JetBrains plugin, refined handling of import paths and module/file location in the schema utilities, and more precise logic in the SDK's utility functions. Additionally, a new integration test addresses a specific regression issue, ensuring robust PostgreSQL database interactions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 3
Configuration used: CodeRabbit UI
Files ignored due to path filters (13)
package.json
is excluded by:!**/*.json
packages/ide/jetbrains/package.json
is excluded by:!**/*.json
packages/language/package.json
is excluded by:!**/*.json
packages/misc/redwood/package.json
is excluded by:!**/*.json
packages/plugins/openapi/package.json
is excluded by:!**/*.json
packages/plugins/swr/package.json
is excluded by:!**/*.json
packages/plugins/tanstack-query/package.json
is excluded by:!**/*.json
packages/plugins/trpc/package.json
is excluded by:!**/*.json
packages/runtime/package.json
is excluded by:!**/*.json
packages/schema/package.json
is excluded by:!**/*.json
packages/sdk/package.json
is excluded by:!**/*.json
packages/server/package.json
is excluded by:!**/*.json
packages/testtools/package.json
is excluded by:!**/*.json
Files selected for processing (5)
- packages/ide/jetbrains/build.gradle.kts (1 hunks)
- packages/schema/src/utils/ast-utils.ts (2 hunks)
- packages/schema/src/utils/pkg-utils.ts (3 hunks)
- packages/sdk/src/utils.ts (2 hunks)
- tests/integration/tests/regression/issue-1129.test.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- packages/ide/jetbrains/build.gradle.kts
Additional comments: 4
tests/integration/tests/regression/issue-1129.test.ts (1)
- 1-1: Consider adding a brief comment at the top of the file explaining the purpose of the test suite and the specific regression issue it addresses. This enhances maintainability by providing context to future contributors.
packages/schema/src/utils/pkg-utils.ts (1)
- 8-9: The type definition for
FindUp
is clear and well-documented. However, consider adding an example usage in the comment to further clarify how this type is intended to be used, especially the distinction between returning a single path versus multiple paths.packages/schema/src/utils/ast-utils.ts (1)
- 21-22: The addition of imports for
findNodeModulesFile
andisAbsolute
is appropriate for the enhancements made to theresolveImportUri
function. Ensure that these imported functions are thoroughly tested in their respective modules to maintain overall reliability.packages/sdk/src/utils.ts (1)
- 218-231: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [221-245]
The update to the
isIdField
function to use field names for comparison is a thoughtful improvement, especially for handling fields inherited from abstract bases. This change enhances the function's ability to accurately identify ID fields in complex inheritance scenarios. Ensure that comprehensive tests cover these scenarios to validate the correctness of the updated logic.
Summary by CodeRabbit
New Features
Refactor
Tests