Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main (v1.11.0) #1146

Merged
merged 3 commits into from
Mar 16, 2024
Merged

merge dev to main (v1.11.0) #1146

merged 3 commits into from
Mar 16, 2024

Conversation

ymc9
Copy link
Member

@ymc9 ymc9 commented Mar 16, 2024

Summary by CodeRabbit

  • New Features

    • Updated JetBrains IDE plugin to version 1.11.0.
    • Enhanced schema resolution capabilities to support both relative and absolute paths.
    • Introduced a new utility function for locating Node module/files.
  • Refactor

    • Improved type definitions and consistency in utility functions.
    • Updated logic for identifying ID fields in SDK to better handle inheritance and cloned identities.
  • Tests

    • Added a new integration test for regression related to PostgreSQL database operations.

Copy link
Contributor

coderabbitai bot commented Mar 16, 2024

Walkthrough

Walkthrough

This update brings enhancements across various packages, including the JetBrains IDE plugin, schema utilities, and the SDK. Key improvements include the version bump of the JetBrains plugin, refined handling of import paths and module/file location in the schema utilities, and more precise logic in the SDK's utility functions. Additionally, a new integration test addresses a specific regression issue, ensuring robust PostgreSQL database interactions.

Changes

Files Change Summary
packages/ide/jetbrains/build.gradle.kts Updated JetBrains IDE plugin version from "1.10.3" to "1.11.0".
packages/schema/src/utils/ast-utils.ts Enhanced resolveImportUri function for better path handling; added imports for findNodeModulesFile and isAbsolute.
packages/schema/src/utils/pkg-utils.ts Added findNodeModulesFile function; refined type definitions and minor adjustments.
packages/sdk/src/utils.ts Improved isIdField function logic for field name comparison.
tests/integration/.../issue-1129.test.ts Added a test case for regression issue 1129 involving PostgreSQL database operations.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 3

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 336abf4 and f8f214d.
Files ignored due to path filters (13)
  • package.json is excluded by: !**/*.json
  • packages/ide/jetbrains/package.json is excluded by: !**/*.json
  • packages/language/package.json is excluded by: !**/*.json
  • packages/misc/redwood/package.json is excluded by: !**/*.json
  • packages/plugins/openapi/package.json is excluded by: !**/*.json
  • packages/plugins/swr/package.json is excluded by: !**/*.json
  • packages/plugins/tanstack-query/package.json is excluded by: !**/*.json
  • packages/plugins/trpc/package.json is excluded by: !**/*.json
  • packages/runtime/package.json is excluded by: !**/*.json
  • packages/schema/package.json is excluded by: !**/*.json
  • packages/sdk/package.json is excluded by: !**/*.json
  • packages/server/package.json is excluded by: !**/*.json
  • packages/testtools/package.json is excluded by: !**/*.json
Files selected for processing (5)
  • packages/ide/jetbrains/build.gradle.kts (1 hunks)
  • packages/schema/src/utils/ast-utils.ts (2 hunks)
  • packages/schema/src/utils/pkg-utils.ts (3 hunks)
  • packages/sdk/src/utils.ts (2 hunks)
  • tests/integration/tests/regression/issue-1129.test.ts (1 hunks)
Files skipped from review due to trivial changes (1)
  • packages/ide/jetbrains/build.gradle.kts
Additional comments: 4
tests/integration/tests/regression/issue-1129.test.ts (1)
  • 1-1: Consider adding a brief comment at the top of the file explaining the purpose of the test suite and the specific regression issue it addresses. This enhances maintainability by providing context to future contributors.
packages/schema/src/utils/pkg-utils.ts (1)
  • 8-9: The type definition for FindUp is clear and well-documented. However, consider adding an example usage in the comment to further clarify how this type is intended to be used, especially the distinction between returning a single path versus multiple paths.
packages/schema/src/utils/ast-utils.ts (1)
  • 21-22: The addition of imports for findNodeModulesFile and isAbsolute is appropriate for the enhancements made to the resolveImportUri function. Ensure that these imported functions are thoroughly tested in their respective modules to maintain overall reliability.
packages/sdk/src/utils.ts (1)
  • 218-231: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [221-245]

The update to the isIdField function to use field names for comparison is a thoughtful improvement, especially for handling fields inherited from abstract bases. This change enhances the function's ability to accurately identify ID fields in complex inheritance scenarios. Ensure that comprehensive tests cover these scenarios to validate the correctness of the updated logic.

packages/schema/src/utils/pkg-utils.ts Show resolved Hide resolved
packages/schema/src/utils/ast-utils.ts Show resolved Hide resolved
@ymc9 ymc9 added this pull request to the merge queue Mar 16, 2024
Merged via the queue into main with commit 599444c Mar 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants