fix(polymorphism): wrong query result when selecting "_count"

[ymc9]

Fixes #1123

Summary by CodeRabbit

• New Features
  • Enhanced data handling capabilities in runtime operations.
• Tests
  • Added integration test for regression related to issue 1123.

[coderabbitai]

Walkthrough

Walkthrough

This update enhances the DelegateProxyHandler class to better handle field processing by iterating over entity entries and differentiating between data models. It introduces methods for assembling data in both directions, aiming to address issues with incorrect query results, specifically when counting related entities. Additionally, a new test case ensures the resolution of a regression, reinforcing the integrity of query functionalities.

Changes

Files	Change Summary
.../src/enhancements/delegate.ts	Updated to improve handling of field processing based on model information
.../tests/enhancements/with-delegate/...	Added a test case for regression related to incorrect query results when counting related entities

Assessment against linked issues

Objective	Addressed	Explanation
Investigate and resolve error related to generating PrismaClient enhancer with unique constraint name issues (#1058)	❌	The changes do not address schema generation or unique constraint name issues.
Resolve the issue of incorrect query result when "_count" is included in select clause (#1123)	✅
Propose a solution by adding a map property to address uniqueness constraint issue in the schema (#1058)	❌	The changes do not involve modifications to schema attributes or the addition of a map property.
Ensure compatibility and functionality with PostgreSQL while utilizing ZenStack and Prisma in a PostgreSQL database (#1058)	❌	The changes do not explicitly mention database compatibility or adjustments for PostgreSQL.

Related issues

• None of the objectives from the similarity-matched issue Error when generating from schema with polymorphic models - given constraint name ... has to be unique in the following namespace... #1058 are directly addressed by the changes in this PR, suggesting that it might not be relevant to link this particular issue. The primary focus of the PR is on handling field processing and addressing a specific regression (Incorrect query result when "_count" is included in select clause #1123), rather than resolving schema generation or database-specific issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e34c530 and 8be5b35.

Files selected for processing (2)

• packages/runtime/src/enhancements/delegate.ts (2 hunks)
• tests/integration/tests/enhancements/with-delegate/issue-1123.test.ts (1 hunks)

Additional comments: 4

tests/integration/tests/enhancements/with-delegate/issue-1123.test.ts (2)

• 3-39: The test setup, including schema definition and data creation, is well-structured and relevant to the issue being tested. However, consider adding more diverse data to thoroughly test the polymorphic relationships and _count functionality across different scenarios.
• 41-45: The assertion correctly verifies the primary scenario related to issue Incorrect query result when "_count" is included in select clause #1123. Consider adding more assertions to cover edge cases, such as querying for content with no likes or multiple likes, to ensure comprehensive test coverage.

packages/runtime/src/enhancements/delegate.ts (2)

• 1106-1136: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1109-1177]

The implementation of assembleUp and assembleDown methods to merge entity data across base and derived models is a critical enhancement for handling polymorphic relationships. Ensure thorough testing of these methods, especially in complex inheritance scenarios and when dealing with nested relationships.

• 1106-1136: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-1177]

The enhancements to the DelegateProxyHandler class introduce significant complexity. To ensure maintainability, consider adding detailed comments explaining the logic behind critical sections, especially those involving polymorphic model handling and data assembly. Additionally, evaluate if some of the logic can be refactored into smaller, more manageable methods or helper classes.