fix(trpc): create/upsert routers shouldn't be generated for delegate …

…models
zenstackhq · Jul 9, 2024 · 8c6a517 · 8c6a517
1 parent a4efa6e
commit 8c6a517
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 3 deletions.
diff --git a/packages/plugins/trpc/src/generator.ts b/packages/plugins/trpc/src/generator.ts
@@ -1,15 +1,16 @@
 import {
     CrudFailureReason,
-    PluginError,
-    RUNTIME_PACKAGE,
     ensureEmptyDir,
+    isDelegateModel,
     parseOptionAsStrings,
+    PluginError,
     requireOption,
     resolvePath,
+    RUNTIME_PACKAGE,
     saveProject,
     type PluginOptions,
 } from '@zenstackhq/sdk';
-import { Model } from '@zenstackhq/sdk/ast';
+import { DataModel, isDataModel, Model } from '@zenstackhq/sdk/ast';
 import { getPrismaClientImportSpec, supportCreateMany, type DMMF } from '@zenstackhq/sdk/prisma';
 import fs from 'fs';
 import { lowerCaseFirst } from 'lower-case-first';
@@ -287,10 +288,20 @@ function generateModelCreateRouter(
         };
     }
 
+    const dataModel = zmodel.declarations.find((d): d is DataModel => isDataModel(d) && d.name === model);
+    if (!dataModel) {
+        throw new Error(`Data model "${model}" not found`);
+    }
+
     createRouterFunc.setBodyText((funcWriter) => {
         funcWriter.write('return router(');
         funcWriter.block(() => {
             for (const [opType, opNameWithModel] of Object.entries(operations)) {
+                if (isDelegateModel(dataModel) && (opType.startsWith('create') || opType.startsWith('upsert'))) {
+                    // delete models don't support create or upsert operations
+                    continue;
+                }
+
                 const baseOpType = opType.replace('OrThrow', '');
                 const inputType = getInputSchemaByOpName(baseOpType, model);
                 const generateOpName = opType.replace(/One$/, '');

diff --git a/tests/integration/tests/enhancements/with-delegate/plugin-interaction.test.ts b/tests/integration/tests/enhancements/with-delegate/plugin-interaction.test.ts
@@ -22,4 +22,20 @@ describe('Polymorphic Plugin Interaction Test', () => {
             extraDependencies: ['@tanstack/react-query'],
         });
     });
+
+    it('trpc', async () => {
+        const schema = `
+        ${POLYMORPHIC_SCHEMA}
+
+        plugin trpc {
+            provider = '@zenstackhq/trpc'
+            output = '$projectRoot/routers'
+        }
+        `;
+
+        await loadSchema(schema, {
+            compile: true,
+            extraDependencies: ['@trpc/client', '@trpc/server'],
+        });
+    });
 });