Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve slackbot answer quality #79

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Improve slackbot answer quality #79

merged 3 commits into from
Sep 22, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Sep 6, 2023 •
edited
Loading

  • made some tweaks to improve the answer quality of the bot (mainly around which data gets used, but also upgraded from gpt3.5 -> 4 and bumping the temperature param to 1 (from 0))
  • ran the formatting script on the entire repo (so anything outside the /langchain-llamaindex-slackbot folder was autofixes by ruff from that)
  • add a script that (re)deploys both bots

@strickvl strickvl added enhancement New feature or request internal labels Sep 6, 2023
@strickvl strickvl requested review from fa9r and bcdurak September 6, 2023 11:49
@dagshub
Copy link

dagshub bot commented Sep 6, 2023

Join the discussion on DagsHub!

fa9r
fa9r approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@fa9r fa9r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Very nice you added a deployment script 🚀

langchain-llamaindex-slackbot/src/constants.py Show resolved Hide resolved
langchain-llamaindex-slackbot/src/main.py Show resolved Hide resolved
langchain-llamaindex-slackbot/src/pipelines/index_builder.py Show resolved Hide resolved
langchain-llamaindex-slackbot/src/steps/web_url_loader.py Show resolved Hide resolved
langchain-llamaindex-slackbot/src/chat_lanarky.py Show resolved Hide resolved
@strickvl strickvl merged commit 9e1b09a into main Sep 22, 2023
3 checks passed
@strickvl strickvl deleted the bug/improve-slackbot-answer-quality branch September 22, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fa9r fa9r fa9r approved these changes

@bcdurak bcdurak Awaiting requested review from bcdurak

Assignees
No one assigned
Labels
enhancement New feature or request internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strickvl @fa9r