chore: Refactored createMessageHandler and added error logs as sugges…

…ted by code rabbit. Co-authored-by: Erik Wiens <[email protected]>
zenml-io · Jul 15, 2024 · e238f28 · e238f28
1 parent 5594a86
commit e238f28
Showing 1 changed file with 23 additions and 15 deletions.
diff --git a/src/commands/pipelines/DagRender.ts b/src/commands/pipelines/DagRender.ts
@@ -119,24 +119,13 @@ export default class DagRenderer {
           break;
         }
 
-        case 'artifactUrl': {
-          if (deploymentType === 'cloud') {
-            const uri = vscode.Uri.parse(
-              `${dashboardUrl}/artifact-versions/${message.id}?tab=overview`
-            );
-            vscode.env.openExternal(uri);
-            break;
-          }
-          const uri = vscode.Uri.parse(runUrl);
-          vscode.env.openExternal(uri);
+        case 'artifactUrl':
+          this.openArtifactUrl(message.id, dashboardUrl, deploymentType, runUrl);
           break;
-        }
 
-        case 'stepUrl': {
-          const uri = vscode.Uri.parse(runUrl);
-          vscode.env.openExternal(uri);
+        case 'stepUrl':
+          this.openStepUrl(runUrl);
           break;
-        }
       }
     };
   }
@@ -153,6 +142,7 @@ export default class DagRenderer {
       vscode.commands.executeCommand('zenmlPanelView.focus');
     } catch (e) {
       vscode.window.showErrorMessage(`Unable to retrieve step ${id}: ${e}`);
+      console.error(e);
     }
   }
 
@@ -181,9 +171,27 @@ export default class DagRenderer {
       vscode.commands.executeCommand('zenmlPanelView.focus');
     } catch (e) {
       vscode.window.showErrorMessage(`Unable to retrieve artifact version ${id}: ${e}`);
+      console.error(e);
     }
   }
 
+  private openArtifactUrl(
+    id: string,
+    dashboardUrl: string,
+    deploymentType: string,
+    runUrl: string
+  ): void {
+    const uri = vscode.Uri.parse(
+      deploymentType === 'cloud' ? `${dashboardUrl}/artifact-versions/${id}?tab=overview` : runUrl
+    );
+    vscode.env.openExternal(uri);
+  }
+
+  private openStepUrl(runUrl: string): void {
+    const uri = vscode.Uri.parse(runUrl);
+    vscode.env.openExternal(uri);
+  }
+
   private async renderDag(panel: vscode.WebviewPanel, node: PipelineTreeItem) {
     const client = LSClient.getInstance();