Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Python 3.8 from the github workflows #24

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Removing Python 3.8 from the github workflows #24

merged 1 commit into from
Oct 10, 2024

Conversation

bcdurak
Copy link
Contributor

@bcdurak bcdurak commented Sep 24, 2024

Summary by CodeRabbit

  • Chores
    • Updated the CI workflow to support only Python versions 3.9, 3.10, 3.11, and 3.12, removing Python 3.8 from the testing matrix.

@bcdurak bcdurak requested a review from avishniakov September 24, 2024 14:41
Copy link

coderabbitai bot commented Sep 24, 2024

Walkthrough

The pull request modifies the GitHub Actions workflow by updating the python-version matrix in the .github/workflows/ci.yml file. It removes Python version "3.8" from the list of supported versions, leaving "3.9", "3.10", "3.11", and "3.12". This change impacts the environments for the CI jobs by excluding Python 3.8 from the testing matrix.

Changes

File Change Summary
.github/workflows/ci.yml Removed "3.8" from the python-version matrix; updated to support "3.9", "3.10", "3.11", and "3.12".

Poem

🐰 In the garden where code does bloom,
Python versions dance and zoom.
Out goes three-point-eight, hooray!
Newer friends come out to play.
With every test, we hop with glee,
For cleaner paths, we code so free! 🌼


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 081cccc and 9128c4b.

Files selected for processing (1)
  • .github/workflows/ci.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/ci.yml (1)

44-44: LGTM! Removal of Python 3.8 support confirmed.

The change aligns with the PR objective of removing Python 3.8 support from the CI workflow.

To ensure consistency across the project, please run the following script to verify the minimum supported Python version in other relevant files:

This script will help identify any inconsistencies in Python version specifications across the project.

Consider the following recommendations:

  1. Update the project's documentation (README, installation guides, etc.) to reflect the new minimum supported Python version.
  2. If this change impacts users, consider adding a note in the changelog or release notes about dropping Python 3.8 support.
  3. Review and update any CI/CD pipelines, Docker images, or development environment setups that might still reference Python 3.8.
Verification successful

Verified: Python 3.8 support has been successfully removed from the CI workflow and no lingering references were found in the relevant files.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify minimum supported Python version in relevant files

# Check setup.py or pyproject.toml for Python version specification
echo "Checking setup.py or pyproject.toml:"
rg --type python "python_requires" setup.py pyproject.toml

# Check README or other documentation files for Python version mentions
echo "Checking README and docs for Python version mentions:"
rg --type md "python 3\.[89]" README.md docs/

# Check any requirements files for Python version specifications
echo "Checking requirements files:"
rg "python_version" requirements*.txt

# Check for any lingering Python 3.8 references in the codebase
echo "Checking for any remaining Python 3.8 references:"
rg "python 3\.8" --type python --type yaml

Length of output: 672


Script:

#!/bin/bash
# Description: Verify minimum supported Python version in relevant files

# Function to check if a command exists
command_exists () {
    command -v "$1" >/dev/null 2>&1
}

# Check if ripgrep is installed
if ! command_exists rg ; then
    echo "ripgrep (rg) is not installed. Please install it to proceed."
    exit 1
fi

# Check setup.py or pyproject.toml for Python version specification
echo "Checking setup.py or pyproject.toml for python_requires:"
rg "python_requires" setup.py pyproject.toml || echo "No python_requires specification found."

# Check README or other documentation files for Python version mentions
echo "Checking README and documentation for Python version mentions:"
if [ -d "docs" ]; then
    rg -i "python 3\.[89]" README.md docs/ || echo "No mentions of Python 3.8 or 3.9 found in README or docs."
else
    echo "docs/ directory does not exist. Skipping documentation check."
    rg -i "python 3\.[89]" README.md || echo "No mentions of Python 3.8 or 3.9 found in README."
fi

# Check any requirements files for Python version specifications
echo "Checking requirements files for python_version specifications:"
rg "python_version" requirements*.txt || echo "No python_version specifications found in requirements files."

# Check for any lingering Python 3.8 references in the codebase
echo "Checking for any remaining Python 3.8 references in Python and YAML files:"
rg "python 3\.8" --glob "*.py" --glob "*.yaml" || echo "No remaining Python 3.8 references found."

Length of output: 1432


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@bcdurak bcdurak changed the title Removing Python 3.8 support Removing Python 3.8 from the github workflows Sep 24, 2024
@bcdurak bcdurak merged commit 4dbef59 into main Oct 10, 2024
13 checks passed
@bcdurak bcdurak deleted the 2024.09.24 branch October 10, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants