-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NLP use-case template without Model Control Plane #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i would say we merge this and make a tag asap :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The README could do with a bit of love to go into more detail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice. I think once you take a look at these I'd want to test it out as well but basically looks good aside from these small nits.
template/Makefile
Outdated
zenml stack set $${stack_name} && \ | ||
zenml stack up | ||
|
||
install-remote-stack: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left in by accident?
| Notifications on failure | Whether to notify about pipeline failures | True | | ||
| Notifications on success | Whether to notify about pipeline successes | False | | ||
| ZenML Server URL | Optional URL of a remote ZenML server for support scripts | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we use this anywhere?
## Next Steps | ||
|
||
Once you have generated the project using this template, you can explore the generated code and customize it to fit your specific NLP use case. The README.md file in the generated project provides further instructions on how to set up and run the project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just realised that there's also this (template/README.md
) that is already merged on the repo etc. I am not sure if it needs revising or not. Seems like maybe it does? In any case, probably needs attention.
Also since this is a template that'll be used in lots of different ways, might be worth making the extra effort to add docstrings etc in (+ maybe helped by darglint to make sure you've actually done it etc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wanted to add that a lot of times youre using list
or dict
instead of typing.List
etc (dosnt work on p38) and some imports i found missing sometimes (like Annotated)... Might want to recheck all that too
Co-authored-by: Alex Strick van Linschoten <[email protected]>
No description provided.