Artifact Control Plane #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avishniakov
suggested changes
Nov 23, 2023
template/run.py
Outdated
| f"`{str(artifact.get_artifact_id())}`." | ||
| ) | ||
| client = Client() | ||
| model_version = client.get_model_version("e2e_use_case", "staging") |
There was a problem hiding this comment.
This will not work, because once you first run a pipeline composition on a clean environment there is no staging model version, so it will fail to retrieve. I suggest you remove this part for now and I'll follow up on this in https://zenml.atlassian.net/browse/OSS-2669
|
@fa9r I pushed changes here to speed up a bit |
avishniakov
restored the
feature/OSS-2190-data-as-first-class-citizen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
Adjusted template to changes from zenml-io/zenml#1943
Pre-requisites
Please ensure you have done the following:
ref-zenmlin.github/workflows/ci.ymlaccordingly (if you don't know -mainwould be a solid choice)Types of changes