-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework template to better use MCP capabilities #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithub.com/zenml-io/template-e2e-batch into feature/OSS-2598-simplify-promotion-logic
avishniakov
changed the title
Simplify promotion logic
Rework template to better use MCP capabilities
Nov 7, 2023
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 37.8%, saving 836.38 KB.
|
htahir1
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe changes
I restructured the example a bit to make it more MCP-focused. Some steps got aggregated in the promotion stage to do promotion in MCP and MR in one shot, not stressing much on MR. Also, MLFlow deployment in inference is pulled into the prediction step.
This PR also introduces the Deployment Pipeline as an extra layer being nicely glued together by the Model Control Plane. Due to the fact, that we are a bit limited on deployers flexibility at the moment - we only really deploy a service on the local orchestrator using MLFlow deployer, otherwise model will be loaded to memory on inference, and the deployment pipeline becomes kinda dummy then.
New flow:
README is up-to-date, but with draft ugly pictures - to be done still, if we confirm the approach
Before:
After
Also, I used MCP capabilities to keep track of the model registry version and to demonstrate how we can glue things together with artifact metadata.
Pre-requisites
Please ensure you have done the following:
ref-zenml
in.github/workflows/ci.yml
accordingly (if you don't know -main
would be a solid choice)Types of changes