Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the template for Model Control Plane #15

Merged

Conversation

avishniakov
Copy link
Contributor

@avishniakov avishniakov commented Oct 19, 2023

Describe changes

I reworked the e2e template to use Model Control Plane to be used as a reference in docs and as learning/templating material by users.

Pre-requisites

Please ensure you have done the following:

  • If my change requires a change to docs, I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • I have updated ref-zenml in .github/workflows/ci.yml accordingly (if you don't know - main would be a solid choice)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@avishniakov avishniakov marked this pull request as ready for review October 19, 2023 10:10
@strickvl strickvl added enhancement New feature or request internal labels Oct 19, 2023
Copy link
Contributor

@strickvl strickvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small nits, but otherwise LGTM!

template/README.md Outdated Show resolved Hide resolved
template/train_config.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@avishniakov avishniakov requested a review from strickvl October 31, 2023 10:01
@strickvl strickvl added the documentation Improvements or additions to documentation label Nov 1, 2023
assets/05_batch_inference.png Outdated Show resolved Hide resolved
template/train_config.yaml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
avishniakov and others added 2 commits November 1, 2023 11:56
@avishniakov avishniakov requested a review from strickvl November 1, 2023 10:59
@avishniakov avishniakov merged commit 4e614bd into main Nov 1, 2023
13 checks passed
@avishniakov avishniakov deleted the feature/OSS-2487-rework-the-template-for-model-control-plane branch November 10, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants