YAML based config #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not really familiar with config best practices so I'm tagging @bcdurak instead who worked on this before I believe |
|
MacOS tests are broken, to be followed up here |
strickvl
reviewed
Oct 13, 2023
strickvl
approved these changes
Oct 13, 2023
template/config.yaml
Outdated
There was a problem hiding this comment.
Nothing to do with this, but while I can see that people might prefer this kind of config for simple configurations, but I find this a decent bit less clear than having a Python-based config.
There was a problem hiding this comment.
Yeah, I also prefer Python, but it is breaking caching logic currently and might not lead to a new pipeline version generated in ZenML on config update.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reworked the template to use the YAML configuration instead of the Python file. This makes this template reusable for a broader count of use cases and makes it aligned with general ZenML configuration best practices.
extraconfig via YAML{"range":{"start":1,"end":10,"step":2}}is used.get_model_from_configstep to reconstruct ClassifierMixin from string-based configurationsDepends on zenml-io/zenml#1876