Fix MLflow registry methods with empty metadata #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
fa9r
approved these changes
Sep 27, 2023
.github/workflows/ci.yml
Outdated
| @@ -35,3 +35,4 @@ jobs: | |||
| with: | |||
| stack-name: ${{ matrix.stack-name }} | |||
| python-version: ${{ matrix.python-version }} | |||
| ref-zenml: bugfix/OSS-2475-fix-mlflow-registry | |||
There was a problem hiding this comment.
This we need to undo before merge right?
Suggested change
| ref-zenml: bugfix/OSS-2475-fix-mlflow-registry |
There was a problem hiding this comment.
Not necessarily, anyway, it will need adjustment upon the next PR, so it can be kept. But I added it to make tests run smoothly. We can remove it after Macos completes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting zenml-io/zenml#1843
@fa9r , once we merge this, we need a new release here and update it in the core references. I already validated these changes from this branch with your branch in core.