Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruff #119

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Bump ruff #119

merged 1 commit into from
Dec 19, 2023

Conversation

strickvl
Copy link
Contributor

@strickvl strickvl commented Dec 5, 2023

Bugfixes for ruff format command

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation
    accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting
    develop. If your branch wasn't based on develop read
    Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)
  • Other (add details above)

@strickvl strickvl requested review from safoinme, bcdurak and fa9r and removed request for safoinme December 5, 2023 09:03
@fa9r
Copy link
Contributor

fa9r commented Dec 6, 2023

Generally speaking, does it even make sense to bump the version if that does nothing?

@strickvl
Copy link
Contributor Author

strickvl commented Dec 6, 2023

Generally speaking, does it even make sense to bump the version if that does nothing?

ruff format command is new, as is the functionality. These early releases (as was the case with the main ruff functionality) fix quite a few bugs on their end. Makes sense to want it not cause headaches for us going forward. So tiny pain now hopefully offsets issues going down the road. Will make somewhat regular updates of this in the next month or so so as to ensure these bugfixes are part of what we're using.

@strickvl strickvl merged commit 19441f7 into develop Dec 19, 2023
34 checks passed
@strickvl strickvl deleted the misc/bump-ruff-bugfix branch December 19, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants