Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exported yaml output for stack creation on k3d #112

Merged
merged 1 commit into from
Nov 23, 2023

Conversation

strickvl
Copy link
Contributor

Our k3d recipe mistakenly included container registries as exported for all components when this didn't apply when we were only including a minio artifact store e.g.

This PR fixes that.

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • If my change requires a change to docs, I have updated the documentation
    accordingly.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting
    develop. If your branch wasn't based on develop read
    Contribution guide on rebasing branch to develop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    change)
  • Other (add details above)

@strickvl strickvl added bug Something isn't working internal labels Nov 17, 2023
@strickvl strickvl requested a review from safoinme November 17, 2023 13:34
@strickvl strickvl merged commit f59be6b into develop Nov 23, 2023
34 checks passed
@strickvl strickvl deleted the bugfix/container-registry-accidental-addition-k3d branch November 23, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants