This repository has been archived by the owner on Jan 30, 2020. It is now read-only.
[hotfix/45] - recursive check for roles #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalbundyra
suggested changes
Aug 6, 2019
There was a problem hiding this comment.
@traviskentbeste Thanks for your contribution. I guess you've seen my comment #45 (comment)
Your solution is not full, and if we gonna bring back recursive check we need to:
- update also
getRolemethod to work recursively - update the docs
We need also fix CS issues (please run composer cs-check and composer cs-fix for auto fixes) - Travis was not running it due to invalid env var (see my PR: #47).
| @@ -121,7 +121,14 @@ public function testHasRole() | |||
| // check that 'snafu' role and $snafu are different | |||
| $this->assertNotEquals($snafu, $this->rbac->getRole('snafu')); | |||
| $this->assertTrue($this->rbac->hasRole('snafu')); | |||
| $this->assertFalse($this->rbac->hasRole($snafu)); | |||
| $this->assertTrue($this->rbac->hasRole($snafu)); | |||
There was a problem hiding this comment.
This is behaviour change, when we provide RoleInstance we expect that Rbac contains the same instance, so we can't compare just names, what I mean:
$role1 = new Role('role');
$role2 = new Role('role');
$role1 !== $role2;There was a problem hiding this comment.
Great catch! Fixed this one.
|
Closing this in favor of #48. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recursive check for roles