Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

Return-Path Email is not used #215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Filipe-Bicho
Copy link

Description

E-mail Return-Path is not set correctly because it only uses the last forced e-mail address, so as workaround I implemented this code change to give priority to the e-mail address that is already stored in the parameters and therefore the return path mail will be set correctly.

E.g. $parameters = " '-f [email protected]' '-f [email protected]'";
It will use '[email protected]' as return path email.

Magento 2.3.0 Alpha: steps to reproduce

 1 - Admin store: Stores > Settings > Configuration > Advanced > System > Mail Sending Settings > Return-Path Email - set a different return path email
 2 - Place an order
 3 - Look for ´Return-Path: <new return path email>' in the email

E-mail Return-Path is not used because it only uses the last forced e-mail address, so this code change gives priority to the e-mail address that is already stored in the parameters and therefore the return path mail will be set correctly.
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change requires test additions

@weierophinney
Copy link
Member

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#27.

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants