Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

remove Null Transport #195

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

samsonasik
Copy link
Contributor

since composer.json master branch is only support php:^7.1

@weierophinney
Copy link
Member

Please rebase this against develop and change the target branch. Since it's a BC break, it needs to target a new major version.

@weierophinney weierophinney added this to the 3.0.0 milestone Mar 1, 2018
@samsonasik samsonasik changed the base branch from master to develop March 1, 2018 21:33
@samsonasik
Copy link
Contributor Author

@weierophinney I've rebased against develop and change target to develop branch.

@glensc
Copy link
Contributor

glensc commented Mar 6, 2018

i suppose it addresses problem that null is no longer allowed as class names in newer php versions?

and explanation why it's removed not just renamed?

also, fix spelling: Tranport -> Transport,

@samsonasik samsonasik changed the title remove Null Tranport remove Null Transport Mar 6, 2018
@samsonasik
Copy link
Contributor Author

the null transport was mapped to inMemory, so, it is same to use inMemory. Thank you, I've updated PR title Tranport -> Transport,

@weierophinney
Copy link
Member

This repository has been moved to laminas/laminas-mail. If you feel that this patch is still relevant, please re-open against that repository, and reference this issue. To re-open, we suggest the following workflow:

  • Squash all commits in your branch (git rebase -i origin/{branch})
  • Make a note of all changed files (`git diff --name-only origin/{branch}...HEAD
  • Run the laminas/laminas-migration tool on the code.
  • Clone laminas/laminas-mail to another directory.
  • Copy the files from the second bullet point to the clone of laminas/laminas-mail.
  • In your clone of laminas/laminas-mail, commit the files, push to your fork, and open the new PR.
    We will be providing tooling via laminas/laminas-migration soon to help automate the process.

@michalbundyra
Copy link
Member

This repository has been closed and moved to laminas/laminas-mail; a new issue has been opened at laminas/laminas-mail#36.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants